Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changes made to the social media buttons in footer #1094

Merged
merged 8 commits into from
Oct 2, 2023
Merged

fix: changes made to the social media buttons in footer #1094

merged 8 commits into from
Oct 2, 2023

Conversation

DON2604
Copy link
Contributor

@DON2604 DON2604 commented Oct 1, 2023 •
edited
Loading

#1090

closes #1090

👷🏻 Changes made

  • Included the Font Awesome library correctly in the project.
  • The social links in the footer are now directly visible without requiring any user interaction such as hovering.
  • Clicking on these links seamlessly redirects users to the corresponding social media profiles.

📸 Screenshots

image

@github-actions github-actions bot added 🐞 bug This is a patch, generally fixing some bugs. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Oct 1, 2023
github-actions[bot]
github-actions bot reviewed Oct 1, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @DON2604, thank you for raising a pull request.

Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/%F0%9F%91%B7%F0%9F%8F%BB%E2%80%8D%E2%99%82%EF%B8%8F%20status%3A%20awaiting%20triage which means that work for this issue is on hold and we are waiting for the maintainers/owner to review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this pull request is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Oct 1, 2023
@tamalCodes tamalCodes changed the title fix: social media buttons ar now visible in footer and are made fully functioning fix: changes made to the social media buttons in footer Oct 1, 2023
tamalCodes
tamalCodes requested changes Oct 1, 2023
View reviewed changes
index.html Outdated Show resolved Hide resolved
src/components/Footer/Footer.jsx Show resolved Hide resolved
@tamalCodes tamalCodes added area/ui This issue is related to frontend/interface fix. status: wip 👩🏻‍💻 This issue/PR is actively being worked on. hacktoberfest-accepted This PR is accepted for Hacktoberfest. and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Oct 1, 2023
@DON2604
Copy link
Contributor Author

DON2604 commented Oct 1, 2023

I have removed the contact button from the socials section of the footer and used react-fonts to make the necessary changes.

Screenshot

image

tamalCodes
tamalCodes approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 🎉

The changes look good to me and will be merged soon.

Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !

Happy Opensource 🚀.

@tamalCodes tamalCodes added status: ready ✅ This PR has passed all the checks and is now ready to be merged. and removed status: wip 👩🏻‍💻 This issue/PR is actively being worked on. labels Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

This pull request has been deployed to Vercel.

Latest commit: a4edf8f
✅ Preview: https://milan-7nv5fm5hr-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan/7tRndcWutNpsd2sBG8FMYa3CjVtw

View Workflow Logs

@tamalCodes tamalCodes merged commit 5733f70 into ngoworldcommunity:main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@tamalCodes tamalCodes tamalCodes approved these changes

Assignees

@DON2604 DON2604

Labels
area/ui This issue is related to frontend/interface fix. 🐞 bug This is a patch, generally fixing some bugs. deployed This PR has been deployed to Vercel for testing. hacktoberfest-accepted This PR is accepted for Hacktoberfest. status: ready ✅ This PR has passed all the checks and is now ready to be merged.
Projects
Milan
Status: Merged/Discarded
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞Bug: Social media icons not visible in footer
2 participants
@DON2604 @tamalCodes