Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: deprecate ng modules #196

Merged
merged 10 commits into from
Jan 15, 2024
Merged

Conversation

NachoVazquez
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

We support two different APIs: NgModules and Standalone provider* functions to provide our dependencies.

provider* functions are the recommended API, and having both APIs impacts our bundle size.

Fixes: #190

What is the new behavior?

We have deprecated Lumberjack NgModules, and we will remove them in v18.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGES: NgModules are deprecated.

@NachoVazquez NachoVazquez requested a review from LayZeeDK January 7, 2024 23:02
Copy link

nx-cloud bot commented Jan 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 331f64b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


⌛ The following target is in progress

✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

Copy link

sonarqubecloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@NachoVazquez NachoVazquez merged commit 882638d into main Jan 15, 2024
12 checks passed
@NachoVazquez NachoVazquez deleted the feature/190-deprecate-ng-modules branch January 15, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate NgModules in favor of the Standalone provider functions API
1 participant