Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate to ngx-deploy-npm v8 #200

Merged
merged 1 commit into from
Jan 23, 2024
Merged

build: migrate to ngx-deploy-npm v8 #200

merged 1 commit into from
Jan 23, 2024

Conversation

NachoVazquez
Copy link
Contributor

@NachoVazquez NachoVazquez commented Jan 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes: #198

What is the new behavior?

Update ngx-deploy-npm to 8.0.0.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Original PR by @dianjuar

More information about the changes and their motivation can be found on this blog post

Copy link

nx-cloud bot commented Jan 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 405bb25. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@NachoVazquez
Copy link
Contributor Author

@all-contributors please add @dianjuar for ideas and code

Copy link
Contributor

@NachoVazquez

I've put up a pull request to add @dianjuar! 🎉

@NachoVazquez NachoVazquez merged commit 08b54ba into main Jan 23, 2024
12 checks passed
@NachoVazquez NachoVazquez deleted the ngx-deploy-npm-v8 branch January 23, 2024 13:24
NachoVazquez added a commit that referenced this pull request Jan 28, 2024
Adds @dianjuar as a contributor for ideas, code.

This was requested by NachoVazquez [in this
comment](#200 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Nacho Vazquez <[email protected]>
NachoVazquez added a commit that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants