Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lumberjack, angular peer dependency versions #202

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

NachoVazquez
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

We didn't update the Lumberjack peer dependencies when upgrading to Angular 16

What is the new behavior?

We use the proper peer dependencies for Lumberjack and Angular 16

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link

nx-cloud bot commented Jan 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3180705. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@NachoVazquez NachoVazquez merged commit 52ebcb7 into main Jan 24, 2024
12 checks passed
@NachoVazquez NachoVazquez deleted the fix/lumberjack-peer-dependencies branch January 24, 2024 14:06
NachoVazquez added a commit that referenced this pull request Jan 28, 2024
## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] The commit message follows our guidelines: CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

```
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
```

## What is the current behavior?

We didn't update the Lumberjack peer dependencies when upgrading to
Angular 16

## What is the new behavior?

We use the proper peer dependencies for Lumberjack and Angular 16

## Does this PR introduce a breaking change?

```
[ ] Yes
[x] No
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant