Fix another bug in g2 grading. #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
another typo. combo should have been combo2, like all the other nearby lines.
|
@zaphod77 Does this fix not break replays? So we don't need to increase replay version? What I mean by that is, the mechanical side of the replay is unaffected, despite the change affecting scoring. |
|
Actually, since G2 has fading/invisible roll based on grade, the fix needs to be changed to check replay version, not applying it for the current replay version, applying it for the replay version after fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another typo. combo should have been combo2, like all the other nearby lines.