-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple block queue pruning from block announcements #3027
Open
ii-cruz
wants to merge
2
commits into
albatross
Choose a base branch
from
iicruz/remove_live_sync_no_gaps_invariant2
base: albatross
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+31
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ii-cruz
force-pushed
the
iicruz/remove_live_sync_no_gaps_invariant2
branch
4 times, most recently
from
November 8, 2024 21:31
e04db33
to
168621a
Compare
styppo
reviewed
Nov 12, 2024
styppo
reviewed
Nov 12, 2024
ii-cruz
force-pushed
the
iicruz/remove_live_sync_no_gaps_invariant2
branch
2 times, most recently
from
November 12, 2024 23:54
d7731e7
to
09c424d
Compare
ii-cruz
changed the title
Restrict concurrent missing block requests to current batch
Decouple block queue pruning from block announcements
Nov 13, 2024
ii-cruz
force-pushed
the
iicruz/remove_live_sync_no_gaps_invariant2
branch
from
December 5, 2024 19:04
09c424d
to
1a88c62
Compare
…lock requests. Buffer blocks if no missing block requests should be induced
ii-cruz
force-pushed
the
iicruz/remove_live_sync_no_gaps_invariant2
branch
from
January 7, 2025 14:05
1a88c62
to
1e04238
Compare
paberr
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Eligioo
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
The live sync has an invariant that all blocks come with no gaps from the gossip sub.
Before #2982 we had a bug where peers (active validators) were being miscategorized as not synced. Thus we would ignore their blocks from the gossip sub, creating gaps during the syncing process. Every gap would generate a missing blocks request from the head of our node to the block announced in the gossip sub, thus creating too many overlapping requests across multiple batches, leading to the issue reported by community #2954.
This PR changes the following:
This PR no longer restricts the request missing blocks to the current batch. The following changes were dropped in favor of tighter rate limiting on the gossipsub #3008:
Pull request checklist
clippy
andrustfmt
warnings.