As validator, check keys per epoch #3077
Open
+38
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisou
reviewed
Nov 16, 2024
| // Compare configured validator signing key to the one in the current epoch to make sure it is the same. | ||
| if epoch_validator.signing_key != self.signing_key().public { | ||
| panic!("Invalid validator configuration: Configured signing key does not match signing key in this epoch"); | ||
| } |
There was a problem hiding this comment.
As discussed in-person just now: the check below that checks against the staking contract can probably be removed.
nibhar
force-pushed
the
nibhar/check-keys
branch
3 times, most recently
from
65019c3 to
c016f48
Compare
nibhar
force-pushed
the
nibhar/check-keys
branch
from
c016f48 to
cf8da80
Compare
|
@nibhar can this PR get rebased? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since keys can change, this PR adds a basic check to the validator which makes sure its keys are consistent with the ones the election block expects. Similar checks are introduced to signing Level updates and Micro blocks such that a validator will not produce blocks if the keys do not match and not sign any LevelUpdates.