Draft: Store decompressed BlsPublicKeys in IndexedDB #3174
Conversation
|
Without understanding/thoroughly reading the code: is this Indexeddb cache optional? Will it fail without crashing the client? Indexeddb might not be available in all browser contexts nor in NodeJS, so this needs to be purely optional and not affect the client if not available or unwritable/unreadable for any other reason. |
Yes, it's in an |
There was a problem hiding this comment.
There's still an error in the web client compilation:
Generating main WASM for target nodejs...
error:
it looks like the Rust project used to create this Wasm file was linked against
version of wasm-bindgen that uses a different bindgen format than this binary:
rust Wasm file schema version: 0.2.95
this binary schema version: 0.2.97
Currently the bindgen format is unstable enough that these two schema versions
must exactly match. You can accomplish this by either updating this binary or
the wasm-bindgen dependency in the Rust project.
You should be able to update the wasm-bindgen dependency with:
cargo update -p wasm-bindgen --precise 0.2.97
don't forget to recompile your Wasm file! Alternatively, you can update the
binary with:
cargo install -f wasm-bindgen-cli --version 0.2.95
if this warning fails to go away though and you're not sure what to do feel free
to open an issue at https://github.com/rustwasm/wasm-bindgen/issues!
| futures = { workspace = true } | ||
| gloo-timers = { version = "0.3", features = ["futures"] } | ||
| hex = "0.4" | ||
| js-sys = "0.3" | ||
| log = { workspace = true } | ||
| rand_core = "0.6.4" | ||
| idb = "0.6.4" |
| for key in keys { | ||
| let mut result = Vec::new(); | ||
| key.uncompress() | ||
| .unwrap() |
There was a problem hiding this comment.
Is it the function's contract that you may only pass valid keys? If so, we should specify that in the documentation. If not, we should not unwrap here, but skip the iteration instead.
|
|
||
| for key in keys { | ||
| let mut result = Vec::new(); | ||
| key.uncompress() |
There was a problem hiding this comment.
This is a potentially expensive operation. We should probably tell the caller that the keys should have been uncompressed before already.
| .serialize_with_mode(&mut result, Compress::No) | ||
| .unwrap(); | ||
| let public_key = hex::encode(&result); | ||
| let compressed_key = hex::encode(key.compressed().serialize_to_vec()); |
There was a problem hiding this comment.
Can the data also be stored without the hex encoding, i.e. directly as bytes in the IndexedDB?
|
|
||
| spawn_local(async move { | ||
| loop { | ||
| let (hash, reason, reverted_blocks, adopted_blocks) = | ||
| let (hash, reason, reverted_blocks, adopted_blocks_hashs) = |
There was a problem hiding this comment.
| let (hash, reason, reverted_blocks, adopted_blocks_hashs) = | |
| let (hash, reason, reverted_blocks, adopted_block_hashes) = |
| let args = Array::new(); | ||
| args.push(&hash.to_hex().into()); | ||
| args.push(&reason.into()); | ||
| args.push(&reverted_blocks); | ||
| args.push(&adopted_blocks); | ||
| args.push(&adopted_blocks.clone()); |
There was a problem hiding this comment.
| args.push(&adopted_blocks.clone()); | |
| args.push(&adopted_blocks); |
| #[derive(Serialize, Deserialize, Debug)] | ||
| struct BlsKeyEntry { | ||
| compressed_key: String, | ||
| public_key: String, |
There was a problem hiding this comment.
We talked about adding a "last used" field so we can apply some sort of cache eviction in the future.
|
The wasm-bindgen version missmatch will go away when rebasing on top of |
hrxi
force-pushed
the
fiaxh/bls_browser_cache
branch
from
670dcb5 to
ec4de84
Compare
|
Rebased on top of albatross. |
Pull request checklist
clippyandrustfmtwarnings.