Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/modules: pass inputs.nixpkgs into evalNixvim #2670

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

MattSturgeon
Copy link
Member

Expose our locked nixpkgs as the nixpkgs.source module options.

This only happens when evalNixvim is part of a lib that was provided flake as an argument.

Stubbed the nixpkgs.source option for now. Eventually, this will be used to construct pkgs internally. For now, it's purely informational.

This is another small step towards #1784. See also #2022

Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Expose our locked nixpkgs as the `nixpkgs.source` module options.

This only happens when `evalNixvim` is part of a lib that was provided
`flake` as an argument.

Stubbed the `nixpkgs.source` option for now. Eventually, this will be
used to construct `pkgs` internally. For now, it's purely informational.
@MattSturgeon
Copy link
Member Author

@mergify queue

Copy link
Contributor

mergify bot commented Dec 15, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at bef9feb

Copy link
Contributor

mergify bot commented Dec 15, 2024

This pull request, with head sha bef9feb446a9203a1343a5026970396bcae60f6f, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha bef9feb446a9203a1343a5026970396bcae60f6f is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch lib_flake_inputs, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit bef9feb into nix-community:main Dec 15, 2024
4 checks passed
@MattSturgeon MattSturgeon deleted the lib_flake_inputs branch December 15, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants