plugins/copilot-lua: migrate to mkNeovimPlugin #2742
+348
−229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeitorAugustoLN
force-pushed
the
copilot-lua-migrate
branch
4 times, most recently
from
259664b to
95d347d
Compare
HeitorAugustoLN
force-pushed
the
copilot-lua-migrate
branch
from
95d347d to
4daa8dd
Compare
GaetanLepage
requested changes
Jan 5, 2025
| jumpPrev = keymapOption "[[" "Keymap for jumping to the previous suggestion."; | ||
|
|
||
| jumpNext = keymapOption "]]" "Keymap for jumping to the next suggestion."; | ||
| keymapOption = defaultNullOpts.mkNullableWithRaw (with types; either (enum [ false ]) str); |
There was a problem hiding this comment.
Suggested change
| keymapOption = defaultNullOpts.mkNullableWithRaw (with types; either (enum [ false ]) str); | |
| mkKeymapOption = defaultNullOpts.mkNullableWithRaw (with types; either (enum [ false ]) str); |
It makes it clearer that it is a function.
| name = "copilot-lua"; | ||
| moduleName = "copilot"; | ||
| packPathName = "copilot.lua"; | ||
| package = "copilot-lua"; |
There was a problem hiding this comment.
Suggested change
| package = "copilot-lua"; |
package defaults to name.
| keymap = { | ||
| accept = keymapOption "<M-l>" "Keymap for accepting the suggestion."; | ||
| filetypes = | ||
| defaultNullOpts.mkAttrsOf types.bool |
There was a problem hiding this comment.
Can you take this opportunity to switch to mkAttrsOf' and provide the example key ?
| copilot_node_command = lib.mkOption { | ||
| type = types.str; | ||
| default = lib.getExe pkgs.nodejs-18_x; | ||
| example = lib.getExe pkgs.nodejs; |
There was a problem hiding this comment.
Suggested change
| example = lib.getExe pkgs.nodejs; | |
| example = lib.literalExpression "lib.getExe pkgs.nodejs"; |
I guess.
| }; | ||
| }; | ||
| }; | ||
| settingsExample = { |
There was a problem hiding this comment.
Please, keep this example shorter as it is the one that will be used in the documentation.
Target 5-10 options only.
The example test case in the test file can be as big as you want though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.