Add .clearfix utility to style #3
Conversation
There was a problem hiding this comment.
Hi @nkverse ,
Good job so far! 👏👏👏
There are some issues that you still need to work on to go to the next project but you're almost there!
To Highlight 🎉
- Good use of GitHub tools ✅
Required Changes ♻️
- 🛑 kindly includes an explanation, a "why", for each requested change. For example:
This is a well-explained request: Why don't you use an article tag for the .first-article element instead of a div, that would improve the HTML structure and make the page more accessible
This request lacks a "why": Why don't you use an article tag here instead of a div?
-
🛑 as mentioned by the requirements you need to have at least two inline comments currently you only have one
-
🛑your comments should be clear and easy to understand. For Example:
- This is a clear comment: The README's "Built With" and "Getting Started" sections are currently empty. Why don't you add content, listing the technology used in the project and how to run it, to them so your README is more informative and professional?
- This is a vague comment: The README is not descriptive, why don't you make it better?
Optional suggestions
- N/A
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Congrats on pushing this feature.
I have looked at your commit but unfortunately your PR won't be accepted.
Why?
CSS has advanced a lot, we now have Grid, Flexbox, Column and it makes the need for floats useless, for that reason we won't allow float in our codebase unless there's a big need for it
in this project we don't need to use floats. Thank you for the PR!
| @@ -112,3 +112,9 @@ a { | |||
| a:hover { | |||
| opacity: 0.7; | |||
| } | |||
|
|
|||
| .clearfix::after { | |||
There was a problem hiding this comment.
Good job with the utility name. it makes total sense and it is easy to remember!
| @@ -112,3 +112,9 @@ a { | |||
| a:hover { | |||
| opacity: 0.7; | |||
| } | |||
|
|
|||
| .clearfix::after { | |||
| display: table; | |||
There was a problem hiding this comment.
Why did you choose table, can we achieve the same results with block?
There was a problem hiding this comment.
STATUS: APPROVED ✅
Hi @nkverse 👋
Your project is complete!
Congratulations! 🎉
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Added
floatis used