fixup! sqlite: support ArrayBuffer and TypedArray in StatementSync

nodejs · Dec 28, 2024 · 79ca6ef · 79ca6ef
1 parent 3a1dfea
commit 79ca6ef
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/doc/api/sqlite.md b/doc/api/sqlite.md
@@ -326,7 +326,7 @@ added: v22.5.0
 
 * `namedParameters` {Object} An optional object used to bind named parameters.
   The keys of this object are used to configure the mapping.
-* `...anonymousParameters` {null|number|bigint|string|Buffer|Uint8Array|TypedArray|DataView} Zero or
+* `...anonymousParameters` {null|number|bigint|string|Buffer|Uint8Array|TypedArray} Zero or
   more values to bind to anonymous parameters.
 * Returns: {Array} An array of objects. Each object corresponds to a row
   returned by executing the prepared statement. The keys and values of each
@@ -358,7 +358,7 @@ added: v22.5.0
 
 * `namedParameters` {Object} An optional object used to bind named parameters.
   The keys of this object are used to configure the mapping.
-* `...anonymousParameters` {null|number|bigint|string|Buffer|Uint8Array|TypedArray|DataView} Zero or
+* `...anonymousParameters` {null|number|bigint|string|Buffer|Uint8Array|TypedArray} Zero or
   more values to bind to anonymous parameters.
 * Returns: {Object|undefined} An object corresponding to the first row returned
   by executing the prepared statement. The keys and values of the object
@@ -378,7 +378,7 @@ added: v23.4.0
 
 * `namedParameters` {Object} An optional object used to bind named parameters.
   The keys of this object are used to configure the mapping.
-* `...anonymousParameters` {null|number|bigint|string|Buffer|Uint8Array|TypedArray|DataView} Zero or
+* `...anonymousParameters` {null|number|bigint|string|Buffer|Uint8Array|TypedArray} Zero or
   more values to bind to anonymous parameters.
 * Returns: {Iterator} An iterable iterator of objects. Each object corresponds to a row
   returned by executing the prepared statement. The keys and values of each
@@ -397,7 +397,7 @@ added: v22.5.0
 
 * `namedParameters` {Object} An optional object used to bind named parameters.
   The keys of this object are used to configure the mapping.
-* `...anonymousParameters` {null|number|bigint|string|Buffer|Uint8Array|TypedArray|DataView} Zero or
+* `...anonymousParameters` {null|number|bigint|string|Buffer|Uint8Array|TypedArray} Zero or
   more values to bind to anonymous parameters.
 * Returns: {Object}
   * `changes`: {number|bigint} The number of rows modified, inserted, or deleted

diff --git a/test/parallel/test-sqlite-typed-array.js b/test/parallel/test-sqlite-typed-array.js
@@ -25,6 +25,7 @@ const TypedArrays = [
   ['Float64Array', Float64Array],
   ['BigInt64Array', BigInt64Array],
   ['BigUint64Array', BigUint64Array],
+  ['DataView', DataView],
 ];
 
 suite('StatementSync with TypedArray', () => {