Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/tsx #56392

Closed
wants to merge 2 commits into from
Closed

Feat/tsx #56392

wants to merge 2 commits into from

Conversation

sibelius
Copy link

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Dec 29, 2024
JakobJingleheimer
JakobJingleheimer requested changes Dec 29, 2024
View reviewed changes
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not appear to handle JSX within a .tsx file

See #56322

@sibelius
Copy link
Author

what is the workaround for this right now ?

@marco-ippolito
Copy link
Member

marco-ippolito commented Dec 29, 2024 •
edited
Loading

Hi @sibelius this topic was already discussed here:
#56322
Before tsx, jsx needs to be supported. It requires to figure out a way to support the different jsx flavors without configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobJingleheimer JakobJingleheimer JakobJingleheimer requested changes

Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sibelius @nodejs-github-bot @marco-ippolito @JakobJingleheimer