Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: fixing url change in load sync hook chain #56402

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/modules/cjs/loader.js
Original file line number Diff line number Diff line change
Expand Up @@ -1144,7 +1144,7 @@ function getDefaultLoad(url, filename) {
return function defaultLoad(urlFromHook, context) {
// If the url is the same as the original one, save the conversion.
const isLoadingOriginalModule = (urlFromHook === url);
const filenameFromHook = isLoadingOriginalModule ? filename : convertURLToCJSFilename(url);
const filenameFromHook = isLoadingOriginalModule ? filename : convertURLToCJSFilename(urlFromHook);
awto marked this conversation as resolved.
Show resolved Hide resolved
const source = defaultLoadImpl(filenameFromHook, context.format);
// Format from context is directly returned, because format detection should only be
// done after the entire load chain is completed.
Expand Down
29 changes: 29 additions & 0 deletions test/module-hooks/test-module-hooks-load-url-change.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
'use strict';

const common = require('../common');
const assert = require('assert');
const { registerHooks } = require('module');
const fixtures = require('../common/fixtures');

// This tests shows the url parameter in `load` can be changed in the `nextLoad` call

const hook = registerHooks({
resolve(specifier, context, nextLoad) {
awto marked this conversation as resolved.
Show resolved Hide resolved
assert.strictEqual(specifier, 'rfs');
return {
url: 'file:///rfs',
shortCircuit: true,
};
},
load: common.mustCall(function load(url, context, nextLoad) {
assert.strictEqual(url, 'file:///rfs');
return nextLoad(
fixtures.fileURL('module-hooks', `redirected-fs.js`).href,
context
awto marked this conversation as resolved.
Show resolved Hide resolved
);
}),
});

assert.strictEqual(require('rfs').exports_for_test, 'redirected fs');

hook.deregister();
JakobJingleheimer marked this conversation as resolved.
Show resolved Hide resolved