test: add initial source map ecma426 coverage #56436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source map has been standardized as ECMA426, with a developing test suite. Add an initial coverage of the source map tests.
nodejs-github-bot
added
build
legendecas
changed the title
aduh95
reviewed
Jan 2, 2025
cjihrig
approved these changes
Jan 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56436 +/- ##
==========================================
- Coverage 88.53% 88.53% -0.01%
==========================================
Files 657 657
Lines 190741 190761 +20
Branches 36607 36616 +9
==========================================
+ Hits 168881 168894 +13
- Misses 15036 15045 +9
+ Partials 6824 6822 -2 |
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
approved these changes
Jan 4, 2025
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
legendecas
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56436 ✔ Done loading data for nodejs/node/pull/56436 ----------------------------------- PR info ------------------------------------ Title test: add initial source map ecma426 coverage (#56436) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch legendecas:test/test426 -> nodejs:main Labels build, author ready, needs-ci, source maps, commit-queue-squash Commits 3 - test: add initial test426 coverage - Update test/test426/test-source-map-spec.mjs - Update test/test426/test-source-map-spec.mjs Committers 2 - Chengzhong Wu <[email protected]> - GitHub <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56436 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56436 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - Update test/test426/test-source-map-spec.mjs ℹ This PR was created on Thu, 02 Jan 2025 14:45:26 GMT ✔ Approvals: 3 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/56436#pullrequestreview-2527728181 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56436#pullrequestreview-2529533770 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/56436#pullrequestreview-2530655776 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-01-04T12:33:30Z: https://ci.nodejs.org/job/node-test-pull-request/64338/ - Querying data for job/node-test-pull-request/64338/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12612138282 |
|
Landed in f97a7b6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source map has been standardized as ECMA426, with a developing test
suite. Add an initial coverage of the source map tests.
An automated updater shall be added in a follow-up.