Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip test-sqlite-extensions when it is missing #56455

Closed
wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 3, 2025

49acdc8 disabled the test when building with --shared-sqlite, but there are more cases where the extension is not built, and IMO we should not report it as failure and instead skip the test.

Fixes: #56453

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 3, 2025
@Jayman2000
Copy link

I can confirm that this PR fixes the problem for me. When I follow the steps to reproduce in #56453 with this PR’s branch, the test prints this…

(node:115653) ExperimentalWarning: SQLite is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
1..0 # Skipped: Missing libsqlite_extension binary

…and exits with exit status 0.

@cjihrig
Copy link
Contributor

cjihrig commented Jan 3, 2025

I think the change here will become obsolete once #56446 lands.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (bf3bc4e) to head (93f933a).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56455      +/-   ##
==========================================
- Coverage   88.54%   88.53%   -0.01%     
==========================================
  Files         657      657              
  Lines      190765   190765              
  Branches    36611    36613       +2     
==========================================
- Hits       168908   168894      -14     
- Misses      15036    15044       +8     
- Partials     6821     6827       +6     

see 24 files with indirect coverage changes

@aduh95
Copy link
Contributor Author

aduh95 commented Jan 5, 2025

@Jayman2000 can you try with latest main to see if #56446 has fixed your issue?

@Jayman2000
Copy link

@Jayman2000 can you try with latest main to see if #56446 has fixed your issue?

I’m not able to reproduce this issue with the main branch any more.

@aduh95 aduh95 closed this Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLite extensions test fails with error: ‘The "path" argument must be of type string. Received undefined’
5 participants