Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: use LocalVector in more places #56457

Closed
wants to merge 3 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 3, 2025

Separated out from another PR.

@jasnell jasnell requested review from anonrig, targos and aduh95 January 3, 2025 19:13
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jan 3, 2025
@nodejs-github-bot

This comment was marked as outdated.

This comment was marked as outdated.

src/env.h Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 3, 2025

@jasnell jasnell force-pushed the jasnell/more-localvector branch from bb474e0 to a9de0b9 Compare January 3, 2025 22:38
src/env.h Outdated Show resolved Hide resolved
src/env.h Outdated Show resolved Hide resolved
Co-authored-by: Anna Henningsen <[email protected]>
src/env.h Outdated Show resolved Hide resolved
@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jan 4, 2025
jasnell added a commit that referenced this pull request Jan 5, 2025
PR-URL: #56457
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Jan 5, 2025

Landed in b736028

@jasnell jasnell closed this Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants