tools: remove github reporter #56468
Open
+2
−20,318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
meta
|
@cjihrig I'm not sure if I went overboard deleting stuff, lmk. |
Ceres6
commented
Jan 4, 2025
| @@ -317,7 +317,7 @@ def HasRun(self, output): | |||
| class ActionsAnnotationProgressIndicator(DotsProgressIndicator): | |||
| def AboutToRun(self, case): | |||
| case.additional_flags = case.additional_flags.copy() if hasattr(case, 'additional_flags') else [] | |||
| case.additional_flags.append('--test-reporter=./tools/github_reporter/index.js') | |||
| case.additional_flags.append('--test-reporter=./test/common/test-error-reporter.js') | |||
There was a problem hiding this comment.
This is actually not available yet, so we would need an intermediate value or waiting for #56438 and rebasing
There was a problem hiding this comment.
I don't mind waiting on the other PR, unless you want to move this fast
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56468 +/- ##
==========================================
- Coverage 88.53% 88.53% -0.01%
==========================================
Files 657 657
Lines 190761 190761
Branches 36616 36617 +1
==========================================
- Hits 168899 168893 -6
+ Misses 15048 15045 -3
- Partials 6814 6823 +9 |
cjihrig
approved these changes
Jan 4, 2025
| @@ -317,7 +317,7 @@ def HasRun(self, output): | |||
| class ActionsAnnotationProgressIndicator(DotsProgressIndicator): | |||
| def AboutToRun(self, case): | |||
| case.additional_flags = case.additional_flags.copy() if hasattr(case, 'additional_flags') else [] | |||
| case.additional_flags.append('--test-reporter=./tools/github_reporter/index.js') | |||
| case.additional_flags.append('--test-reporter=./test/common/test-error-reporter.js') | |||
benjamingr
approved these changes
Jan 5, 2025
atlowChemi
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the github reporter (with much verbose output) in favor of the error reporter in #56438