Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove test-runner-watch-mode-complex flaky designation #56470

Merged
merged 1 commit into from
Jan 6, 2025
Merged

test: remove test-runner-watch-mode-complex flaky designation #56470

merged 1 commit into from
Jan 6, 2025

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jan 4, 2025

Refs: #55006
Refs: #54807 (comment)

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 4, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (b3f82fe) to head (0faa6ed).
Report is 26 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56470      +/-   ##
==========================================
+ Coverage   88.53%   88.54%   +0.01%     
==========================================
  Files         657      657              
  Lines      190719   190761      +42     
  Branches    36605    36611       +6     
==========================================
+ Hits       168848   168906      +58     
- Misses      15040    15046       +6     
+ Partials     6831     6809      -22

see 53 files with indirect coverage changes

@aduh95 aduh95 added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v23.x PRs that should not land on the v23.x-staging branch and should not be released in v23.x. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 4, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/64344/ 💛

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2025
@nodejs-github-bot nodejs-github-bot merged commit 984a472 into nodejs:main Jan 6, 2025
90 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 984a472

@lpinca lpinca deleted the remove/flaky-test-runner-watch-mode-complex branch January 6, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakecastelli jakecastelli jakecastelli approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v23.x PRs that should not land on the v23.x-staging branch and should not be released in v23.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lpinca @nodejs-github-bot @jasnell @jakecastelli @aduh95