Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated, scheduled crowdin sync #7272

Merged
merged 11 commits into from
Dec 5, 2024
Merged

Automated, scheduled crowdin sync #7272

merged 11 commits into from
Dec 5, 2024

Conversation

bmuenzenmeyer
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer commented Nov 21, 2024 •
edited
Loading

Description

Introduces an automated way to initiate crowdin syncs.
In talking with the crowdin team, this seemed to be the logical next step.

Note that this does not replace our existing workflow, which:

  • tells people when they are translating something manually
  • formats incoming PRs to adhere to our standards

Validation

  • Post-merge, we will see what it does - i will run a workflow_dispatch
  • We can also turn it on with dry-run and a workflow trigger. will add that after typing this up
  • Update TRANSLATION guide to reflect this new method

Related Issues

#7121

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@vercel Vercel
Copy link

vercel bot commented Nov 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 5, 2024 1:19pm

@bmuenzenmeyer

This comment was marked as resolved.

Sign in to view
@bmuenzenmeyer bmuenzenmeyer marked this pull request as ready for review November 21, 2024 17:49
@bmuenzenmeyer bmuenzenmeyer requested review from a team as code owners November 21, 2024 17:49
@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Nov 21, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 21, 2024
Copilot
Copilot AI reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 suggestion.

.github/workflows/translations-sync.yml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@bmuenzenmeyer @Copilot
Update .github/workflows/translations-sync.yml
e35936a 
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 5.523s ⏱️

@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Nov 21, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 21, 2024
avivkeller
avivkeller approved these changes Nov 21, 2024
View reviewed changes
.github/workflows/translations-sync.yml Outdated Show resolved Hide resolved
@bmuenzenmeyer
Copy link
Collaborator Author

@nodejs/web-infra one last pass on this would be appreciated

mikeesto
mikeesto reviewed Nov 23, 2024
View reviewed changes
TRANSLATION.md Outdated Show resolved Hide resolved
@bmuenzenmeyer @mikeesto
Update TRANSLATION.md
1dcdff3 
Co-authored-by: Michael Esteban <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Nov 24, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 24, 2024
@bmuenzenmeyer bmuenzenmeyer linked an issue Nov 29, 2024 that may be closed by this pull request
Explore our crowdin integration options #7121
Closed
mikeesto
mikeesto approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AugustinMauroy
AugustinMauroy approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM !!

ovflowd
ovflowd approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good. I can't really validate'em, but if you're confident, let's push it!

We can always iterate afterwards!

bmuenzenmeyer and others added 2 commits December 5, 2024 07:16
@bmuenzenmeyer @ovflowd
Update .github/workflows/translations-sync.yml
7d27852 
Co-authored-by: Claudio W <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer @ovflowd
Update .github/workflows/translations-upload.yml
7a64c04 
Co-authored-by: Claudio W <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Dec 5, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 5, 2024
@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit a904f8e Dec 5, 2024
16 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the crowdin-gh-action branch December 5, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@bjohansebas bjohansebas bjohansebas left review comments

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

@avivkeller avivkeller avivkeller approved these changes

@mikeesto mikeesto mikeesto approved these changes

@ovflowd ovflowd ovflowd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explore our crowdin integration options
6 participants
@bmuenzenmeyer @ovflowd @mikeesto @avivkeller @AugustinMauroy @bjohansebas