Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button focus #7287

Merged
merged 14 commits into from
Dec 16, 2024
Merged

Fix button focus #7287

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
121fe44
add changes to MetaBar index.modul.css
faridomarAf Nov 28, 2024
ad14225
add href to button
faridomarAf Nov 28, 2024
7701f9c
remove unrelated changes
faridomarAf Nov 29, 2024
e8f2eff
apply changes to CodeBox file & Button file
faridomarAf Nov 30, 2024
11057bb
add change to CodeBox file
faridomarAf Nov 30, 2024
6f9fa79
add changes to CodeBox & Button component
faridomarAf Nov 30, 2024
cf0e8f3
import KeyboardEvent & MouseEvent from react at Button index.file
faridomarAf Dec 11, 2024
c4348da
refactor: consolidate React imports into a single line
faridomarAf Dec 11, 2024
e085abf
refactor: consolidate React imports into a single line
faridomarAf Dec 11, 2024
ef1efba
refactor: Button component & CodeBox compnent
faridomarAf Dec 14, 2024
83b524f
Update: Button component modified in case of type-saftey at some part
faridomarAf Dec 14, 2024
eaf25de
omit unnecessary comment-lines, handle-proper naming
faridomarAf Dec 14, 2024
be629eb
omit unnecessary comment-lines, handle-proper naming
faridomarAf Dec 14, 2024
a2b1696
Update apps/site/components/Common/Button/index.tsx
ovflowd Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/site/components/Common/CodeBox/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,12 @@ const CodeBox: FC<PropsWithChildren<CodeBoxProps>> = ({
<span className={styles.language}>{language}</span>

{showCopyButton && (
<Button kind="neutral" className={styles.action} onClick={onCopy}>
<Button
kind="neutral"
className={styles.action}
onClick={onCopy}
href="#"
AugustinMauroy marked this conversation as resolved.
Show resolved Hide resolved
>
<DocumentDuplicateIcon className={styles.icon} />
{t('components.common.codebox.copy')}
</Button>
Expand Down
4 changes: 2 additions & 2 deletions apps/site/components/Containers/MetaBar/index.module.css
View file
Open in desktop
AugustinMauroy marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
dt {
@apply mb-2
text-sm
font-medium
font-[700]
text-neutral-800
dark:text-neutral-200;
}
Expand All @@ -40,7 +40,7 @@
a {
@apply max-xs:inline-block
max-xs:py-1
font-semibold
font-[500]
text-neutral-900
underline
dark:text-white;
Expand Down