Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS structure for country-specific style overrides (#7326) #7327

Merged
merged 3 commits into from
Dec 14, 2024

Conversation

mpruser
Copy link
Contributor

@mpruser mpruser commented Dec 12, 2024

Description

This PR introduces a CSS structure to support country-specific style overrides. The new structure allows defining localized styles efficiently while maintaining global consistency.

Validation

  • Verified that global styles are unaffected by the changes in locals.css.
  • Tested that the styles (line-height: 1.8, word-break: keep-all, word-wrap: break-word) are correctly applied when the HTML lang='ko' attribute is present.
  • Visually compared the text layout before and after applying the Korean-specific styles to ensure proper implementation.
  • Ensured that styles for other languages (e.g., lang='en') remain unchanged.

Related Issues

Fixes #7326

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

@mpruser mpruser requested a review from a team as a code owner December 12, 2024 03:42
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 12, 2024 1:30pm

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there are other languages need this change ?

apps/site/styles/locals.css Outdated Show resolved Hide resolved
@mpruser
Copy link
Contributor Author

mpruser commented Dec 12, 2024

is there are other languages need this change ?

I'm not certain if there are additional languages that would require these specific changes. However, implementing such functionality provides a pathway to address usability issues caused by linguistic differences. I believe this approach is neither excessive nor unnecessary, as it allows for improved accessibility and adaptability in a multilingual context. 🙏

apps/site/styles/locals.css Outdated Show resolved Hide resolved
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 5.082s ⏱️

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@ovflowd ovflowd added this pull request to the merge queue Dec 14, 2024
Merged via the queue into nodejs:main with commit 56fbf91 Dec 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal for a CSS Structure to Support Country-Specific Style Overrides
6 participants