Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Update javanese glyph form #792

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

budiarto-id
Copy link

Update glyph form to common form in javanese. Issue number notofonts/javanese#20

Update glyph form to common form in javanese. Issue number #765
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@budiarto-id
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@marekjez86
Copy link
Contributor

@carakatama : Thank you, thank you very much for the correction. Could you correct the glyphs file (see below) as opposed to the ttf file ? we intend to publish the sources (i.e., *.glyphs files) for Javanese and other scripts. We haven't done it yet. We are almost done, but still not ready with process yet. The glyphs file below is exactly the same as the unhinted ttf on our noto-fonts site.

ttf correction while appreciated is NOT as useful as a correction to the glyphs file :-(.

gNotoSansJavanese.glyphs.zip

@budiarto-id
Copy link
Author

@marekjez86 I want to correct glyphs file, but i haven't glyphs app to do it

@marekjez86
Copy link
Contributor

@carakatama : you gave us a very happy and beneficial problem to solve :-) "how do we accept font contributions? what kind of contributions could we accept? how do we validate contributions (harmonious with the current font? correct? good quality? etc)?"

thank you very much for your work. I looked at the changes and I found them to be well done and harmonious with the current font. What tools did you use? Do you have any other forms of the font besides TTF (e.g., UFOs)?

I realized that we need to validate the font changes with the community. I'm not sure what the process we should use however we need to see the differences on some sample text.

I have found and used the text from https://wikisource.org/wiki/Jv/Hanacaraka (I have no idea what type of text it is).

To see the differences I used fontdiff tool from https://github.com/googlei18n/fontdiff

using javanese.html.zip
as the input and producing the following pdf with difference between the --before (red) and --after (green, one provided by you) fonts
javanese.pdf

@Yakuka , @cahyoramadhani , @mangajapa Does the sample in javanese.pdf look OK?

Is there a more representative text that I could use for a sample?

@tjahaja
Copy link

tjahaja commented Nov 14, 2016

Thank you @marekjez86 and @carakatama. I've seen the comparison (the pdf). It's visually a lot better than the previous one. If possible, I think it would be really helpful for us to check if you could provide the-before-and-after-fonts comparison by showing glyph by glyph or letter by letter.

@marekjez86 Regarding more representative text, these digitized books done by Wikimedia Indonesia & Museum Dewantara Kirti Griya last year would be interesting for you. Nearly all the ebooks contain Javanese scripts, but not machine-readable text.

Since the notofonts/javanese#20 has already many people involved, can this issue be merged with it, so people there also get noticed?

@marekjez86
Copy link
Contributor

@cahyoramadhani : thank you for the feedback. I have attached letter by letter differences (red is old, green is new, overlaps are black). Unfortunately the tool that did the diffs assumed a wrong width of the glyphs. I have no better diff and I filed a bug against the tool.

jv__d_dha__pas
jv__d_ha__pas
jv__l_a__pas
jv__v__i__c_ecak
jv__v__ii__l_ay
uni25c_c_a_9c_0

@adtbayuperdana
Copy link

adtbayuperdana commented Nov 15, 2016

@marekjez86 it is certainly far more readable now; though there are a few things that could improve the overall legibility, for example the glyph's proportion.

untitled-1
To illustrate, I'm going to compare Noto's CA glyph with Javanese Text and Noto Balinese. As you can see, while the glyph of CA is indeed legible, the proportions looks rather off compared to the others. In the middle is my edit of CA, in which I tried to incorporate the proportions of Noto Javanese, Balinese, and Javanese Text. I think Noto Sans Javanese would look better if it would follow the common proportions and typography as Noto Balinese did.

If possible, I'm interested in making the glyph files and I already downloaded the zip from previous posting. What application can I use to open .glyphs?

@marekjez86
Copy link
Contributor

Font editing is not easy :-( I use an app from https://glyphsapp.com/
It has a 30 day no limitations free trial of both mini and a full version. This is only one weight therefore mini might be sufficient, but I'm not certain.

I'm not certain (I'm not aware) of any other applications that would open the glyphs file.

@marekjez86
Copy link
Contributor

Also when I look at your edit it is moving toward Serif like features and we want to keep it Sans (which doesn't mean that you shouldn't/couldn't produce Serif Javanese).

@adtbayuperdana
Copy link

I've made around half a dozen Javanese fonts, so I'm very much interested to give input on the design of this font (you can see several of my works here https://www.behance.net/Alteaven, though I would not say I'm a professional or anything).

I've actually made a sans Javanese font before, with equal width stroke. Noto Javanese has a bit more variations of stroke width, so I guess I've made towards serif a bit much, but that can be adjusted :)

@adtbayuperdana
Copy link

Wait, glyphapp is a mac program? welp, it seems that all i can do is comment...

@marekjez86
Copy link
Contributor

@mangajapa :
Here's another format that we could accept: UFO.
NotoSansJavanese-Regular.ufo.zip

I think https://github.com/trufont/trufont might be able to open it.

Base automatically changed from master to main March 2, 2021 04:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants