Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bulk subscribers creation api #39

Merged

Conversation

Eazybright
Copy link
Contributor

@Eazybright Eazybright commented Oct 2, 2023

This PR adds the functionality to create multiple subscribers at once.
Use Case:

payload = {
    'subscribers' => [
        {
            'name' => 'subscriber-1',
            'email' => '[email protected]',
            'firstName' => 'test1',
            'lastName' => 'test1',
            'phone' => '08122442244',
            'subscriberId' => 'subscriber-test-1221'
        },
        {
            'name' => 'subscriber2',
            'email' => '[email protected]',
            'firstName' => 'test2',
            'lastName' => 'test2',
            'phone' => '0814422334',
            'subscriberId' => 'subscriber-test-9090'
        }
    ]
}
client.create_bulk_subscribers(payload)

amansaini0003
amansaini0003 previously approved these changes Oct 3, 2023
Copy link
Contributor

@unicodeveloper unicodeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let it be bulk create subscribers all over. 🙏🏿

@unicodeveloper
Copy link
Contributor

Please also resolve the merge conflicts @Eazybright

@Eazybright
Copy link
Contributor Author

Please also resolve the merge conflicts @Eazybright

done

@Eazybright
Copy link
Contributor Author

@unicodeveloper i want to ask that at what point is the changes pushed to the gem repository?

@unicodeveloper
Copy link
Contributor

unicodeveloper commented Oct 6, 2023

It will be pushed next week @Eazybright. I have to push manually.

@unicodeveloper
Copy link
Contributor

unicodeveloper commented Oct 6, 2023

On the other hand, if you can figure out how to create a workflow GitHub action that can automatically run to release a new version on rubygem when I tag a new release on GitHub, then that would be fantastic!

E.g if I tag v2.0.0, a github action should run that authenticates with the package on rubygem and publishes a new release. @Eazybright

@unicodeveloper
Copy link
Contributor

The PHP, Kotlin, Java, Python and .NET SDKs automatically publishes when I tag a new release on the GitHub repo.

@Eazybright
Copy link
Contributor Author

On the other hand, if you can figure out how to create a workflow GitHub action that can automatically run to release a new version on rubygem when I tag a new release on GitHub, then that would be fantastic!

E.g if I tag v2.0.0, a github action should run that authenticates with the package on rubygem and publishes a new release. @Eazybright

alright, i will work on it.

Maybe you can create an issue for it for documentation puerpose.

@unicodeveloper
Copy link
Contributor

I'll do that and will assign to you @Eazybright

@unicodeveloper
Copy link
Contributor

Raised the issue here #42 @Eazybright. Please feel free to comment on the issue and ask for assignment.

@unicodeveloper unicodeveloper merged commit 738fdf6 into novuhq:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants