-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests and ci #2
Merged
Merged
Tests and ci #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make more consistent with the `pm_tb_data` repo. We should probably think about re-ogranizing some of these docs into individual files. The README should really just cover front-matter that people need at a glace. A `doc/` directory with individual sections for e.g., development/contributing, testing, etc. (ideally served by e.g., RTD) would be ideal.
* Line length too long * Add missing import
And move config from `mypy.ini` to `pyproject.toml` - consistent with other tool configuration
Ignore some things. This code will likely be refactored greatly over the coming weeks anyway.
These need to be run w/ access to `/ecs/`
No unit tests defined yet.
Eventually this will get set to `main` and we'll have development of `seaice_ecdr` track along with the main branches of `pm_tb_data` and `pm_icecon`.
Experiment with checking out multiple repos in GHA
Removed in favor of using `pyproject.toml`
Updates for the `update_for_nise_cdr_cetb` branch of `pm_icecon`
nsidc-service-admin
pushed a commit
that referenced
this pull request
Jan 9, 2024
Not sure what the hdf5 library error is, but it appears to have to do with `dask` and using `open_mfdataset`. This gets repeated: ``` HDF5-DIAG: Error detected in HDF5 (1.12.2) thread 4: #000: H5A.c line 528 in H5Aopen_by_name(): can't open attribute major: Attribute minor: Can't open object #1: H5VLcallback.c line 1091 in H5VL_attr_open(): attribute open failed major: Virtual Object Layer minor: Can't open object #2: H5VLcallback.c line 1058 in H5VL__attr_open(): attribute open failed major: Virtual Object Layer minor: Can't open object #3: H5VLnative_attr.c line 130 in H5VL__native_attr_open(): can't open attribute major: Attribute minor: Can't open object #4: H5Aint.c line 545 in H5A__open_by_name(): unable to load attribute info from object header major: Attribute minor: Unable to initialize object #5: H5Oattribute.c line 494 in H5O__attr_open_by_name(): can't locate attribute: '_QuantizeGranularBitRoundNumberOfSignificantDigits' major: Attribute minor: Object not found ``` By telling dask not to use more than one thread per worker, these errors go away. See https://stackoverflow.com/questions/72821108/hdf5-warnings-when-accessing-xarray-dataset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit
to do linting/formattingpyproject.toml
mypy
), unit tests, andpre-commit
hooks.Resolved the issue below by merging in Scott's latest changes!
Getting a failure in an integration test designed to ensure that this library's implementation of
compute_initial_daily_ecdr_dataset
return the same result aspm_icecon
's:This error appears when using this repo's
add_qa_field
branch andpm_icecon
'supdate_for_nise_cdr_cetb
, so I don't think this PR is to blame. Just recording this here until we track down the source of the issue.