-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nuxt 3 support #108
feat: nuxt 3 support #108
Conversation
986b0b1
to
c3f37a4
Compare
040a911
to
6b9caad
Compare
@nozomuikuta where are you at? |
@provok-it First of all, don't worry, I do never abandon this PR 🙌 My PR has been blocked by some issues as described in the PR message. The biggest one is nuxt/nuxt#13856. Perhaps can we use other hook like one of Nitro instead of As for other blockers of new features and bug fixes, I would like to hear the author's and the the community's thoughts. By the way, JFYR, I'm also creating an alternative to |
I agree with the idea to provide a "feature-parity" module with Nuxt 3 support for now and then maybe another major version with a rewrite/revamp |
Thank you for quick response! 😄 Then, once nuxt/nuxt#13856 is resolved or we find another way, I will complete minimal implementation and make this PR ready for review. 🙋♂️ I appreciate any kinds of help. 🙏 |
@nozomuikuta Maybe we can use a Nitro endpoint that renders the feed? Users can decide then if they want to pre-render it, use SWR or what not |
@nozomuikuta What do you think about this @pi0? |
Sorry to ask again, but I appreciated if you give us some information based on which we can make decisions about implementation, like we need to await upstream, or we can use a specific hook to achieve our needs. |
@nozomuikuta As I mentioned before, I'd go a similar way as you can add sitemaps now. See e.g. Daniel's blogpost |
Closed in favor of nuxt/framework#114. |
This draft PR aims to take over nuxt/framework#103 and resolves nuxt/framework#106.
At first, for the next major release, I triaged all the open issues as below (except Renovate Dependency Dashboard (#99)).
My implementation may include some breaking changes in API, as done in nuxt/framework#103, in a way that I believe is good and beneficial enough for users. I would like to discuss with authors and community while developing this PR.
This PR doesn't aim to add Docus-powered documentation, which is handled in nuxt/framework#103, so that we can keep this PR's "done of definition" manageable.
This PR message will be modified as needed.
TODOs
LICENSE
CHANGELOG.md
README.md
async-cache
package is deprecated, can nitro's unstorage layer be an alternative?)path
#9@vue/apollo
example implementation nuxt/framework#70 (need spec)sources
option can be a function instead offactory
option)factory
option)Out of Scope
asyncData
nuxt/nuxt#10961 (looks stale)options.css
nuxt/bridge#122