Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nuxt 3 support #108

Closed

Conversation

nozomuikuta
Copy link

@nozomuikuta nozomuikuta commented Jul 21, 2022

This draft PR aims to take over nuxt/framework#103 and resolves nuxt/framework#106.

At first, for the next major release, I triaged all the open issues as below (except Renovate Dependency Dashboard (#99)).

My implementation may include some breaking changes in API, as done in nuxt/framework#103, in a way that I believe is good and beneficial enough for users. I would like to discuss with authors and community while developing this PR.

This PR doesn't aim to add Docus-powered documentation, which is handled in nuxt/framework#103, so that we can keep this PR's "done of definition" manageable.

This PR message will be modified as needed.

TODOs

Out of Scope

@nozomuikuta nozomuikuta force-pushed the feat/nuxt-3-support branch from 986b0b1 to c3f37a4 Compare July 23, 2022 14:25
@nozomuikuta nozomuikuta force-pushed the feat/nuxt-3-support branch from 040a911 to 6b9caad Compare July 23, 2022 18:11
@TheAlexLichter TheAlexLichter self-requested a review July 23, 2022 19:32
@nozomuikuta nozomuikuta mentioned this pull request Jul 24, 2022
@provok-exe
Copy link

@nozomuikuta where are you at?

@nozomuikuta
Copy link
Author

@provok-it

First of all, don't worry, I do never abandon this PR 🙌

My PR has been blocked by some issues as described in the PR message.

The biggest one is nuxt/nuxt#13856.
If I'm correct, this PR can't be completed without the hook.

@manniL

Perhaps can we use other hook like one of Nitro instead of generate hooks?


As for other blockers of new features and bug fixes, feed package doesn't seem to be so actively developed. Since "done is better than perfect", I'm thinking of postponing new features and bug fixes and focusing on making the module support Nuxt 3 at this moment.

I would like to hear the author's and the the community's thoughts.


By the way, JFYR, I'm also creating an alternative to feed package, with which I aim to resolve all the feed-related blockers. If people think it's worth changing the dependency, I could do that at some point (like @nuxt/feed v3?). At least, even if @nuxt/feed keep depending on feed, I would personally publish another feed module powered by my feed generator, just for R&D purpose.

@TheAlexLichter
Copy link
Member

I agree with the idea to provide a "feature-parity" module with Nuxt 3 support for now and then maybe another major version with a rewrite/revamp ☺️

@nozomuikuta
Copy link
Author

@manniL

Thank you for quick response! 😄

Then, once nuxt/nuxt#13856 is resolved or we find another way, I will complete minimal implementation and make this PR ready for review. 🙋‍♂️

I appreciate any kinds of help. 🙏

@TheAlexLichter
Copy link
Member

@nozomuikuta Maybe we can use a Nitro endpoint that renders the feed? Users can decide then if they want to pre-render it, use SWR or what not ☺️

@provok-exe
Copy link

provok-exe commented Nov 15, 2022

@nozomuikuta
You can probably use the build hook since SSG doesn't work in the same way it did in Nuxt 2.
That's what the nuxt/sitemap module does.

What do you think about this @pi0?

@nozomuikuta
Copy link
Author

@pi0 @danielroe

Sorry to ask again, but I appreciated if you give us some information based on which we can make decisions about implementation, like we need to await upstream, or we can use a specific hook to achieve our needs.

@TheAlexLichter
Copy link
Member

TheAlexLichter commented Dec 3, 2022

@nozomuikuta As I mentioned before, I'd go a similar way as you can add sitemaps now. See e.g. Daniel's blogpost

@nozomuikuta nozomuikuta mentioned this pull request Dec 14, 2022
21 tasks
@nozomuikuta
Copy link
Author

Closed in favor of nuxt/framework#114.

@nozomuikuta nozomuikuta deleted the feat/nuxt-3-support branch December 14, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants