fix(latex-renderer): fixed renderer failing silently #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit [8ec38e0](8ec38e0) changed the implementation of the treesitter module's `execute_query` function. The function asks for a non-nil source, but the latex renderer wasn't providing one (which should have caused a type error, but didn't because the way the `module.required` table works prevents lua_ls from getting the function's signature). The previous implementation happened to use a function internally that used the buffer 0 when `source` was omitted to get the parser, which is what allowed the latex renderer to work previously, but the new implementation didn't do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 8ec38e0 changed the implementation of the treesitter module's
execute_queryfunction. The function asks for a non-nil source, but the latex renderer wasn't providing one (which should have caused a type error, but didn't because the way themodule.requiredtable works prevents lua_ls from getting the function's signature). The previous implementation happened to use a function internally that used the buffer 0 whensourcewas omitted to get the parser, which is what allowed the latex renderer to work previously, but the new implementation didn't do that