-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(readme): add nixvim example #123
Conversation
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋
thanks for the PR. As the NixVim interface could change, it would be best to just link to the NixVim docs.
About that, I don't think it really will change since I think it is in a good state right now, lazyLoad.settings is just a freeform settings of the lazy-loading provider, which is probably the best solution. Also if it changes I can update it. But I don't see any problems in linking it to the nixvim docs, if you really want to. |
Sure, we can add the examples, but we should definitely link to the NixVim docs with a note like Note You can find up-to-date NixVim documentation for lazy-loading with lz.n here. |
The CI failure is probably markdownlint. |
Got it. |
8ec6dc5
to
b873d25
Compare
thanks 🙏 one more thing I just realised. The NixVim nixos/home-manager examples look almost identical. |
b873d25
to
980141b
Compare
Done |
980141b
to
2cf1a4f
Compare
Also improved consistency of the examples formatting