Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add nixvim example #123

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

HeitorAugustoLN
Copy link
Contributor

Also improved consistency of the examples formatting

Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(context): some bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

Copy link
Member

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋

thanks for the PR. As the NixVim interface could change, it would be best to just link to the NixVim docs.

@HeitorAugustoLN
Copy link
Contributor Author

As the NixVim interface could change, it would be best to just link to the NixVim docs.

About that, I don't think it really will change since I think it is in a good state right now, lazyLoad.settings is just a freeform settings of the lazy-loading provider, which is probably the best solution. Also if it changes I can update it. But I don't see any problems in linking it to the nixvim docs, if you really want to.

@mrcjkb
Copy link
Member

mrcjkb commented Dec 28, 2024

Sure, we can add the examples, but we should definitely link to the NixVim docs with a note like

Note

You can find up-to-date NixVim documentation for lazy-loading with lz.n here.

@mrcjkb
Copy link
Member

mrcjkb commented Dec 28, 2024

The CI failure is probably markdownlint.

@HeitorAugustoLN
Copy link
Contributor Author

Sure, we can add the examples, but we should definitely link to the NixVim docs with a note like

Note

You can find up-to-date NixVim documentation for lazy-loading with lz.n here.

Got it.

@HeitorAugustoLN HeitorAugustoLN force-pushed the patch-1 branch 4 times, most recently from 8ec6dc5 to b873d25 Compare December 28, 2024 16:20
@mrcjkb
Copy link
Member

mrcjkb commented Dec 28, 2024

thanks 🙏

one more thing I just realised. The NixVim nixos/home-manager examples look almost identical.
I'd suggest just a single NixVim example. Home-manager users will likely know how to enable NixVim.

@HeitorAugustoLN
Copy link
Contributor Author

one more thing I just realised. The NixVim nixos/home-manager examples look almost identical.
I'd suggest just a single NixVim example. Home-manager users will likely know how to enable NixVim.

Done

@mrcjkb mrcjkb changed the title docs: add nixvim examples docs(readme): add nixvim example Dec 28, 2024
@mrcjkb mrcjkb merged commit ffeb54f into nvim-neorocks:master Dec 28, 2024
4 checks passed
@HeitorAugustoLN HeitorAugustoLN deleted the patch-1 branch December 28, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants