Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefer released version over dev package when using auto_install #36

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

simifalaye
Copy link
Contributor

Currently, setting auto_install = true will install the package without a version set which will install the dev package but the "prompt" option will determine the latest version and opt for using the dev package only if one isn't available. This PR aims to have them use the same install strategy for both options.

SIDE NOTE:
It seems the versioned tree-sitter packages require tree-sitter-cli where as the dev version doesn't run into this issue when installing:

Error: Build error: 'tree-sitter CLI' is not installed.
tree-sitter-perl requires the tree-sitter CLI to build.

Is this supposed to be the case?

@mrcjkb
Copy link
Member

mrcjkb commented Sep 19, 2024

Is this supposed to be the case?

This is the case if the parser is not yet available on rocks-binaries.
The nvim-treesitter team have been frequently rebasing their main branch lately, leading to a lot of new versions being published.
I don't have a good solution for this yet, other than triggering a rocks-binaries build from NURR (where the parsers are published), to minimise the impact.

@mrcjkb mrcjkb merged commit 9cddec4 into nvim-neorocks:main Sep 19, 2024
3 checks passed
@mrcjkb mrcjkb mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants