-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add remote package source to lockfile #297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm stuck on the fact that the |
mrcjkb
force-pushed
the
mj/push-lyzszxlmlvkk
branch
from
January 1, 2025 18:43
70b09e3
to
b743830
Compare
mrcjkb
changed the base branch from
mj/push-xyppvtpnxpum
to
mj/push-yzuwlustwxrp
January 3, 2025 13:00
mrcjkb
force-pushed
the
mj/push-lyzszxlmlvkk
branch
from
January 3, 2025 13:00
b743830
to
f207947
Compare
mrcjkb
force-pushed
the
mj/push-yzuwlustwxrp
branch
from
January 3, 2025 13:00
eb2e112
to
ed28a80
Compare
mrcjkb
force-pushed
the
mj/push-lyzszxlmlvkk
branch
from
January 3, 2025 14:25
f207947
to
9cbdd5a
Compare
mrcjkb
force-pushed
the
mj/push-yzuwlustwxrp
branch
from
January 3, 2025 14:25
ed28a80
to
ff26454
Compare
mrcjkb
force-pushed
the
mj/push-lyzszxlmlvkk
branch
from
January 3, 2025 17:41
9cbdd5a
to
1e9cbac
Compare
Stacked this on all the builder pattern refactors. This ended up getting a lot bigger than I originally anticipated (sorry for that 😞). Here's a summary of the changes:
|
mrcjkb
force-pushed
the
mj/push-lyzszxlmlvkk
branch
from
January 3, 2025 18:00
1e9cbac
to
397d470
Compare
mrcjkb
changed the title
feat!: add url to lockfile
feat!: add remote package source to lockfile
Jan 3, 2025
mrcjkb
force-pushed
the
mj/push-lyzszxlmlvkk
branch
from
January 3, 2025 18:13
397d470
to
3535384
Compare
vhyrro
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
RemoteSource
type, which contains information about what type of source (e.g. a Luarocks server) and the URL aLocalPackage
was pulled from.The new field has to be an
Option
, because it's possible to runrocks build
on a local project.