Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#2938): add default filesystem_watchers.ignore_dirs = { "/.ccls-cache", "/build", "/node_modules", "/target", } #2940

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

alex-courtis
Copy link
Member

@alex-courtis alex-courtis commented Oct 5, 2024

fixes #2938

@gegoune this is technically a breaking change, however this has affected too many users. Could it be a bugfix or minor release?

Prior art: junegunn/fzf#3649

@alex-courtis alex-courtis requested a review from gegoune October 5, 2024 01:15
@gegoune
Copy link
Collaborator

gegoune commented Oct 5, 2024

Can't see why someone would not want to ignore that directory. We can go ever further and add more well known directories/files like this. It's also added .gitignoren when creating new project if I am not mistaken. (Feat is fine, or fix if you prefer, makes no difference to me.)

@alex-courtis
Copy link
Member Author

alex-courtis commented Oct 5, 2024

It's also added .gitignoren when creating new project if I am not mistaken.

It should be, but I've seen people not doing it.

We can go ever further and add more well known directories/files like this.

How about:
build meson, clang etc.
target java, cargo; fzf recommends but doesn't default
.ccls-cache c language server

@alex-courtis
Copy link
Member Author

Ignoring .gitignore would be great, however you need to build a compiler/matcher and there's no good library for it.

@alex-courtis alex-courtis reopened this Oct 5, 2024
@alex-courtis alex-courtis changed the title feat(#2938): filesystem_watchers.ignore_dirs defaults to { node_modules } to resolve pathalogical issues feat(#2938): add default filesystem_watchers.ignore_dirs = { "/.ccls-cache", "/build", "/node_modules", "/target", } Oct 7, 2024
@alex-courtis alex-courtis merged commit 010ae03 into master Oct 7, 2024
6 checks passed
@alex-courtis alex-courtis deleted the 2938-default-ignore_dirs-node_modules branch October 7, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nvim freezes when i disable git files
2 participants