Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elixir): correctly match call arguments #605

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

calops
Copy link

@calops calops commented Apr 18, 2024

Function parameters weren't correctly matched in all situations before. The previous queries seemed to be a bit complex to me and I fail to identify why, but maybe I'm missing something?

@ribru17
Copy link
Member

ribru17 commented Apr 19, 2024

I don't know if this is the right change; the elixir parser is very weird sadly (I don't know why): even in something like the following:

if a === true do
   IO.puts "Variable a is true!"
end

this entire block is parsed as a (call) node (what?)! Perhaps there is a very good reason that I am not aware of but either way it makes it difficult to just label anything in a (call) as a @parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants