-
Notifications
You must be signed in to change notification settings - Fork 380
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #149 from NYTimes/develop
Merge `develop` into `master` for v1.0.1
- Loading branch information
Showing
21 changed files
with
148 additions
and
670 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
_While tagging a new version of a library and pushing it to CocoaPods is conceptually simple, there are several fine points which must not be forgotten to produce a polished product._ | ||
|
||
# NYTPhotoViewer Release Process | ||
|
||
- Review [the diff between `master` and `develop`](https://github.com/NYTimes/NYTPhotoViewer/compare/master...develop) to determine which part of the version number to increment, in accordance with [semantic versioning](http://semver.org/). | ||
- Update [the Podspec](https://github.com/NYTimes/NYTPhotoViewer/blob/develop/NYTPhotoViewer.podspec) to the new version number. | ||
- Make this change via a pull request to trigger notifications for those who watch the repository. | ||
- Using [the diff](https://github.com/NYTimes/NYTPhotoViewer/compare/master...develop), [the commit history](https://github.com/NYTimes/NYTPhotoViewer/commits/develop), and any notes about `develop` which may have been written in the `CHANGELOG`, update [`CHANGELOG.md`](https://github.com/NYTimes/NYTPhotoViewer/blob/develop/CHANGELOG.md) with changes in the new version which may affect library users. | ||
- When reviewing the commit history, searching for “Merge pull request” helps find changes which should appear in [the `CHANGELOG`](https://github.com/NYTimes/NYTPhotoViewer/blob/develop/CHANGELOG.md). | ||
- Update any other documentation which still needs to be updated, given those changes. | ||
- Create a pull request merging [`develop` into `master`](https://github.com/NYTimes/NYTPhotoViewer/compare/master...develop). Merge it yourself, immediately. | ||
- Create a Github release, using the new version number (eg. `1.0.0`) as the tag, and the merge commit into `master` as the target. Copy [the `CHANGELOG`](https://raw.githubusercontent.com/NYTimes/NYTPhotoViewer/develop/CHANGELOG.md)’s Markdown content for this release into the Github release. | ||
- Push the new Podspec to Cocoapods Trunk: `pod trunk push NYTPhotoViewer.podspec` | ||
|
||
## CocoaPods Trunk Setup | ||
|
||
Before you can use this process to push a release to CocoaPods: | ||
|
||
- Set up a CocoaPods Trunk account on your machine: [Getting setup with Trunk/Getting started](https://guides.cocoapods.org/making/getting-setup-with-trunk.html#getting-started) | ||
- Become an owner for [NYTPhotoViewer](https://cocoapods.org/pods/NYTPhotoViewer). A current owner will need to run `pod trunk add-owner NYTPhotoViewer [email protected]` |
This file was deleted.
Oops, something went wrong.
27 changes: 0 additions & 27 deletions
27
Example/NYTPhotoViewer-SwiftTests/NYTPhotoCaptionViewTests.swift
This file was deleted.
Oops, something went wrong.
16 changes: 0 additions & 16 deletions
16
Example/NYTPhotoViewer-SwiftTests/NYTPhotoTransitionAnimatorTests.swift
This file was deleted.
Oops, something went wrong.
63 changes: 0 additions & 63 deletions
63
Example/NYTPhotoViewer-SwiftTests/NYTPhotoViewControllerTests.swift
This file was deleted.
Oops, something went wrong.
34 changes: 0 additions & 34 deletions
34
Example/NYTPhotoViewer-SwiftTests/NYTPhotosDataSourceTests.swift
This file was deleted.
Oops, something went wrong.
46 changes: 0 additions & 46 deletions
46
Example/NYTPhotoViewer-SwiftTests/NYTPhotosOverlayViewTests.swift
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.