Team4-Implementation-Final #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new class to wrap the logic needed to implement the `inputs` tool correctly (see Issue ninja-build#2482 for details), and provide a unit-test for it.
This uses the InputsCollector class introduced in the previous patch to implement the tool properly. Results are still shell-escaped and sorted alphabetically. Fixed ninja-build#2482
Add new options to the `inputs` tool in order to change the format of its output: - `--no-shell-escape` to avoid shell-escaping the results. - `--dependency-order` to return results in dependency order, instead of sorting them alphabetically. - `--print0` to use \0 as the list separator in the list, useful to process the target paths with `xargs -0` and similar tools.
waynewangyuxuan
force-pushed
the
new-graph-updated
branch
from
ace523a to
adf7ed9
Compare
change getopt.h so that it looks for local opt if the system is linux or macOS fixed readme
waynewangyuxuan
force-pushed
the
new-graph-updated
branch
from
adf7ed9 to
6bf04c8
Compare
waynewangyuxuan
changed the title
|
|
still feels like there are a lot of parts of this diff that are not part of the task at hand! |
kyotov
reviewed
Dec 12, 2024
| @@ -0,0 +1,68 @@ | |||
|
|
|||
There was a problem hiding this comment.
A lot of this file is not specific to the task at hand.
| @@ -10,6 +10,7 @@ | |||
| /build_log_perftest | |||
| /canon_perftest | |||
| /clparser_perftest | |||
| /elide_middle_perftest | |||
| @@ -3,6 +3,13 @@ cmake_minimum_required(VERSION 3.15) | |||
| include(CheckSymbolExists) | |||
| include(CheckIPOSupported) | |||
|
|
|||
| find_program(CLANG_TIDY_EXE NAMES clang-tidy) | |||
There was a problem hiding this comment.
You are correct, we have it updated at #28
| @@ -228,6 +228,71 @@ def test_tool_inputs(self) -> None: | |||
| out2 | |||
| ''') | |||
|
|
|||
| self.assertEqual(run(plan, flags='-t inputs --dependency-order out3'), | |||
There was a problem hiding this comment.
no, this is the ninja code
There was a problem hiding this comment.
Not necessarily, we can get it removed
Comment on lines
+16
to
+19
| command.AddText("g++"); | ||
| command.AddText(" "); | ||
| command.AddText("-c"); | ||
| command.AddText(" "); |
| @@ -526,7 +526,7 @@ void Plan::ComputeCriticalPath() { | |||
| for (Edge* edge : sorted_edges) | |||
| edge->set_critical_path_weight(EdgeWeightHeuristic(edge)); | |||
|
|
|||
| // Second propagate / increment weidghts from | |||
| // Second propagate / increment weights from | |||
There was a problem hiding this comment.
We are not sure, but we have it updated at #28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shadowdash
This is branch is a experimental feature that deconstrucsts and demonstrates how Ninja create it graphs from buiding a simple
new-graph/hello_world.ccfrom scratch.Do the following:
cd new-graph chmod -x easybuild.sh ./easybuild.shOr your can do it manually:
a. Before building simulate-ninja-graph, you need to compile and generate a shared object that includes partial functionality (functions) of Ninja. You can refer to lines 41 to 67 in
new-graph/easybuild.shto find the .cc files that need to be included.b. After generating the shared object, compile the
new-graph/simulate-ninja-graph.ccfile and link it with the previously built shared object.c. Once completed, run ./simulate-ninja-graph and pass hello_world as an argument (./simulate-ninja-graph hello_world). This program will look for a
new-graph/hello_world.ccfile in the current folder and compile it.d. After the compilation, an executable file named
new-graph/hello_worldwill be created, which you can run.(You can modify easybuild.sh based on your OS and compiler to simplify this process.)