-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Test::More first, fixes too many test errors #213
Conversation
Prior to change saw test failures looking like this: t/99-warnings.t ...... 1/? # Looks like you planned 2 tests but ran 3. t/99-warnings.t ...... Dubious, test returned 255 (wstat 65280, 0xff00) on perl 5.34.0 on ubuntu.
I see the build failed Not sure how to run it for myself and when I try to install anything dzil I get a mess of broken dependencies, but I think it's just formatting, which I would fix if I could get the xt tests to run. |
It's a lot of dependencies, but this should fix it. 😄 diff --git a/t/01-detect.t b/t/01-detect.t
index 4fb9e9b..2b886db 100644
--- a/t/01-detect.t
+++ b/t/01-detect.t
@@ -12,7 +12,6 @@ use Test::More import =>
[qw( cmp_ok diag done_testing is is_deeply ok subtest )];
use Test::Warnings;
-
# test that the module loads without errors
my $w;
{ |
ok I've pushed that. |
I can fix this in Test::Warnings. ..and fixed! |
I'm going to merge this @michael-stevens, but I guess I don't need to release just yet since the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @michael-stevens!
Thanks, I was going to say it may not be needed now…
Michael Stevens
Senior Developer ▪︎ Dianomi
+44 207 802 5530 <+44%20207%20802%205530>
***@***.***
84 Eccleston Square London, SW1V 1PX
www.dianomi.com
…On Fri, 3 Jan 2025 at 18:17, Olaf Alders ***@***.***> wrote:
Merged #213 <#213> into
main.
—
Reply to this email directly, view it on GitHub
<#213 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEC2FISAP3UBZHBFPURG2CL2I3H4FAVCNFSM6AAAAABUR3JCSOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHAYDSOJSGA4TONA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
This e-mail is for the sole use of the intended recipient and contains
information that may be privileged and/or confidential. If you are not an
intended recipient, please notify the sender by return e-mail and delete
this e-mail and any attachments. Certain required legal entity disclosures
can be accessed on our website.
|
It's not needed, but it seems to be more correct. |
Prior to change saw test failures looking like this:
t/99-warnings.t ...... 1/? # Looks like you planned 2 tests but ran 3. t/99-warnings.t ...... Dubious, test returned 255 (wstat 65280, 0xff00)
on perl 5.34.0 on ubuntu.