Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Test::More first, fixes too many test errors #213

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

michael-stevens
Copy link
Contributor

Prior to change saw test failures looking like this:

t/99-warnings.t ...... 1/? # Looks like you planned 2 tests but ran 3. t/99-warnings.t ...... Dubious, test returned 255 (wstat 65280, 0xff00)

on perl 5.34.0 on ubuntu.

Prior to change saw test failures looking like this:

t/99-warnings.t ...... 1/? # Looks like you planned 2 tests but ran 3.
t/99-warnings.t ...... Dubious, test returned 255 (wstat 65280, 0xff00)

on perl 5.34.0 on ubuntu.
@michael-stevens
Copy link
Contributor Author

I see the build failed

Not sure how to run it for myself and when I try to install anything dzil I get a mess of broken dependencies, but I think it's just formatting, which I would fix if I could get the xt tests to run.

@oalders
Copy link
Owner

oalders commented Jan 3, 2025

It's a lot of dependencies, but this should fix it. 😄

diff --git a/t/01-detect.t b/t/01-detect.t
index 4fb9e9b..2b886db 100644
--- a/t/01-detect.t
+++ b/t/01-detect.t
@@ -12,7 +12,6 @@ use Test::More import =>
     [qw( cmp_ok diag done_testing is is_deeply ok subtest )];
 use Test::Warnings;

-
 # test that the module loads without errors
 my $w;
 {

@michael-stevens
Copy link
Contributor Author

It's a lot of dependencies, but this should fix it. 😄

diff --git a/t/01-detect.t b/t/01-detect.t
index 4fb9e9b..2b886db 100644
--- a/t/01-detect.t
+++ b/t/01-detect.t
@@ -12,7 +12,6 @@ use Test::More import =>
     [qw( cmp_ok diag done_testing is is_deeply ok subtest )];
 use Test::Warnings;

-
 # test that the module loads without errors
 my $w;
 {

ok I've pushed that.

@karenetheridge
Copy link

karenetheridge commented Jan 3, 2025

I can fix this in Test::Warnings.

..and fixed!

@oalders
Copy link
Owner

oalders commented Jan 3, 2025

I'm going to merge this @michael-stevens, but I guess I don't need to release just yet since the Test::Warnings fix is already on CPAN. 😄

Copy link
Owner

@oalders oalders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @michael-stevens!

@oalders oalders merged commit 5c89c2b into oalders:main Jan 3, 2025
44 checks passed
@michael-stevens
Copy link
Contributor Author

michael-stevens commented Jan 3, 2025 via email

@oalders
Copy link
Owner

oalders commented Jan 3, 2025

It's not needed, but it seems to be more correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants