Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/exit state #273

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Colstuwjx
Copy link
Contributor

  1. set default stop signal to SIGTERM, now we would trigger SIGKILL finally;
  2. trans p state to Stopping and Stopped if it's triggered by user, rather than exited...

@starInEcust
Copy link

Nice

@Dexus
Copy link

Dexus commented Jun 15, 2021

Hi @Colstuwjx i checked you PR and i see a problem now, if you restart a programm, your changes let hang the status in the stopping status. and you have no chance to restart or stop it then.

@Colstuwjx
Copy link
Contributor Author

@Dexus Thanks for your check, have you been reproduced this restart issue? I couldn't reproduce this issue in mine prod.

Currently, from my view, I think restart a program would let it trans from Running -> Stopping -> Stopped ( at here ) -> Starting -> Running.

How could it stick in Stopping? 😿

@Dexus
Copy link

Dexus commented Jun 17, 2021

I'm not 100% sure.
In our image we see it current very often. that a process is hanging in the stopping line and then we need to restart the whole container because nothing else helps to reset the state.

But maybe it is not only a problem of your commit.

@Colstuwjx
Copy link
Contributor Author

In my prod, I still couldn't reproduce the issue you mentioned.
I'm welcome if you could help me dive into the issue, and propose a fix by forking this repo and take a commit atop of my PR 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants