-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/exit state #273
base: master
Are you sure you want to change the base?
fix/exit state #273
Conversation
Colstuwjx
commented
Jun 8, 2021
- set default stop signal to SIGTERM, now we would trigger SIGKILL finally;
- trans p state to Stopping and Stopped if it's triggered by user, rather than exited...
Nice |
Hi @Colstuwjx i checked you PR and i see a problem now, if you restart a programm, your changes let hang the status in the stopping status. and you have no chance to restart or stop it then. |
I'm not 100% sure. But maybe it is not only a problem of your commit. |
In my prod, I still couldn't reproduce the issue you mentioned. |