Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using curl/tar.gz files for ocp4-helpernode and ocp4-playbooks instead of git #220

Closed
torwen1 opened this issue Jul 5, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@torwen1
Copy link
Contributor

torwen1 commented Jul 5, 2021

I have opened this topic related to #89.

I had a customer with exactly this request, because they could not have a own GitHub server to host clones from ocp4-helpernode and ocp4-playbooks.

I solved it by introducing a tag in var.tfvars (git:). I also changed both helpernode.tf and install.tf the way, that I moved the original git clone in 2 new null_resource definitions running before the. One was checking, if the git: tag was at the beginning of the URL and used the original git clone code.
The 2nd one checked, if it is starting with http: or https: and used curl to pull the packages and uncompressed it. I left the git checkout, to support the helpernode_tag and playbook_tag.

The customer just needed to prepare the tar.gz/tgz by using git clone on one of the clients with internet access, simply packing the whole directory in a tar.gz and uploading it to the HTTP server.

An alternative to the git: tag was to introduce a new variable in var.tfvars to switch between git and curl. But we decided against it, because it could confuse users to think, that all packages (like helm, etc) are downloaded from a GitHub server.

I have the code here, just need to fine tune it with the results of this discussion.

torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Jul 8, 2021
Fixes ocp-power-automation#220

Implementation how I did it at another customer. I have tested it again on our local test env and both (git and curl) was working like it should be.
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Jul 23, 2021
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Jul 23, 2021
Fixes ocp-power-automation#220

Implementation how I did it at another customer. I have tested it again on our local test env and both (git and curl) was working like it should be.

Fixes ocp-power-automation#220 - Swapped to ZIP

Fixes ocp-power-automation#220 - Swapped to ZIP
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Jul 23, 2021
Fixes ocp-power-automation#220

Implementation how I did it at another customer. I have tested it again on our local test env and both (git and curl) was working like it should be.

Fixes ocp-power-automation#220 - Swapped to ZIP

Fixes ocp-power-automation#220 - Swapped to ZIP
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Jul 23, 2021
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Jul 23, 2021
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Jul 23, 2021
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Jul 23, 2021
@bpradipt bpradipt added the enhancement New feature or request label Jul 24, 2021
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Aug 24, 2021
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Aug 24, 2021
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Aug 24, 2021
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Aug 24, 2021
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Aug 24, 2021
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Aug 24, 2021
Fixes ocp-power-automation#220 Wildcard move

Fixes ocp-power-automation#220 Wildcard move

Fixes ocp-power-automation#220 Updated doc

Fixes ocp-power-automation#220 Updated doc

Fixes ocp-power-automation#220 Updated Docu

Fixes ocp-power-automation#220 Updated Docu
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Aug 27, 2021
Fixes ocp-power-automation#220 Wildcard move

Fixes ocp-power-automation#220 Wildcard move

Fixes ocp-power-automation#220 Updated doc

Fixes ocp-power-automation#220 Updated doc

Fixes ocp-power-automation#220 Updated Docu

Fixes ocp-power-automation#220 Updated Docu
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Sep 20, 2021
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Sep 20, 2021
Fixes ocp-power-automation#220 Wildcard move

Fixes ocp-power-automation#220 Wildcard move

Fixes ocp-power-automation#220 Updated doc

Fixes ocp-power-automation#220 Updated doc

Fixes ocp-power-automation#220 Updated Docu

Fixes ocp-power-automation#220 Updated Docu

Update var.tfvars-doc.md

Fixes ocp-power-automation#220
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Sep 22, 2021
Fixes ocp-power-automation#220 Wildcard move

Fixes ocp-power-automation#220 Wildcard move

Fixes ocp-power-automation#220 Updated doc

Fixes ocp-power-automation#220 Updated doc

Fixes ocp-power-automation#220 Updated Docu

Fixes ocp-power-automation#220 Updated Docu

Update var.tfvars-doc.md

Fixes ocp-power-automation#220

Update var.tfvars-doc.md

Updated documentation, that selecting supported branches are also supported
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Apr 6, 2022
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Apr 6, 2022
Fixes ocp-power-automation#220 Wildcard move

Fixes ocp-power-automation#220 Wildcard move

Fixes ocp-power-automation#220 Updated doc

Fixes ocp-power-automation#220 Updated doc

Fixes ocp-power-automation#220 Updated Docu

Fixes ocp-power-automation#220 Updated Docu

Update var.tfvars-doc.md

Fixes ocp-power-automation#220

Update var.tfvars-doc.md

Updated documentation, that selecting supported branches are also supported

Enable external DNS/LB support

Signed-off-by: CS Zhang <[email protected]>

Update the doc

Signed-off-by: CS Zhang <[email protected]>

Update the helpernode_tag to latest level

Signed-off-by: CS Zhang <[email protected]>

Add RHCOS kernel options before installation

Signed-off-by: Aishwarya Kamat <[email protected]>

Allow OCP network customization before installation. (ocp-power-automation#224)

add clusterNetwork_CIDR, serviceNetwork, hostprefix vars

Added cs-zhang as approver

To set mtu on private network

Signed-off-by: Aishwarya Kamat <[email protected]>

remove mkumatag from reviewer list

Not actively involved, hence removing my entry from the reviewers to avoid getting assigned automatically for the review

force centos stream to use ansible 2.9 like rhel8

Accessing cluster using non-root user

Signed-off-by: Aishwarya Kamat <[email protected]>

bastion fqdn with clusterID as subdmain

To remove the scp error with Terraform v1.1.x

Signed-off-by: Aishwarya Kamat <[email protected]>

To Update the Terraform Version

Signed-off-by: Aishwarya Kamat <[email protected]>

FIPS enablement

Signed-off-by: Aishwarya Kamat <[email protected]>
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Apr 6, 2022
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Apr 6, 2022
Fixes ocp-power-automation#220 Wildcard move

Fixes ocp-power-automation#220 Wildcard move

Fixes ocp-power-automation#220 Updated doc

Fixes ocp-power-automation#220 Updated doc

Fixes ocp-power-automation#220 Updated Docu

Fixes ocp-power-automation#220 Updated Docu

Update var.tfvars-doc.md

Fixes ocp-power-automation#220

Update var.tfvars-doc.md

Updated documentation, that selecting supported branches are also supported

Enable external DNS/LB support

Signed-off-by: CS Zhang <[email protected]>

Update the doc

Signed-off-by: CS Zhang <[email protected]>

Update the helpernode_tag to latest level

Signed-off-by: CS Zhang <[email protected]>

Add RHCOS kernel options before installation

Signed-off-by: Aishwarya Kamat <[email protected]>

Allow OCP network customization before installation. (ocp-power-automation#224)

add clusterNetwork_CIDR, serviceNetwork, hostprefix vars

Added cs-zhang as approver

To set mtu on private network

Signed-off-by: Aishwarya Kamat <[email protected]>

remove mkumatag from reviewer list

Not actively involved, hence removing my entry from the reviewers to avoid getting assigned automatically for the review

force centos stream to use ansible 2.9 like rhel8

Accessing cluster using non-root user

Signed-off-by: Aishwarya Kamat <[email protected]>

bastion fqdn with clusterID as subdmain

To remove the scp error with Terraform v1.1.x

Signed-off-by: Aishwarya Kamat <[email protected]>

To Update the Terraform Version

Signed-off-by: Aishwarya Kamat <[email protected]>

FIPS enablement

Signed-off-by: Aishwarya Kamat <[email protected]>

Merging the code ocp-power-automation#220

Merging the code ocp-power-automation#220
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Apr 6, 2022
@torwen1
Copy link
Contributor Author

torwen1 commented Jan 24, 2023

Closed because it is no longer applicable.

@torwen1 torwen1 closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants