Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplemented and merged code for #220 #244

Closed

Conversation

torwen1
Copy link
Contributor

@torwen1 torwen1 commented Apr 6, 2022

Reimplemented and merged code for #220

The original pull request go stuck in conflict issue and I could not solve it without being afraid of breaking something else. So I merged the code in a new branch based on the actual master of the project and created a new pull request

@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: torwen1
To complete the pull request process, please assign cs-zhang after the PR has been reviewed.
You can assign the PR to them by writing /assign @cs-zhang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot
Copy link

Hi @torwen1. Thanks for your PR.

I'm waiting for a ocp-power-automation member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ppc64le-cloud-bot
Copy link

ppc64le-cloud-bot commented Jun 20, 2022

@torwen1: PR is not mergeable.

The PR state is: dirty

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rajalakshmi-Girish
Copy link

Rajalakshmi-Girish commented Sep 4, 2022

@torwen1: PR is not mergeable.

The PR state is: DIRTY

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@torwen1
Copy link
Contributor Author

torwen1 commented Jan 24, 2023

Can be closed because it is no longer applicable

@torwen1 torwen1 closed this Jan 24, 2023
@torwen1 torwen1 deleted the New-Implementation-of-#220 branch January 24, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants