Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Specs #19

Open
wants to merge 105 commits into
base: fix/redirect_user_intented_page
Choose a base branch
from

Conversation

alecslupu
Copy link

🎩 What? Why?

Please describe your pull request.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

andreslucena and others added 30 commits October 16, 2024 16:41
* Add schema.org Event serializer for Breadcrumb

* Skip empty items

* Add name to BreadcrumbList schema

* Fix rubocop offense

* Fix specs
* remove nested

* add reload

* debug

* manually set tokens

* add sleep

* cleanup
* Fix @tarekraafat/autocomplete.jsversion upgrade

* Lock @tarekraafat/autocomplete.js version to 10.2.7

* Trigger pipelines
* Remove realtime training

* Fix @tarekraafat/autocomplete.jsversion upgrade

* Lock @tarekraafat/autocomplete.js version to 10.2.7

* Trigger pipelines

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Update docs/modules/develop/pages/ai_tools/spam_detection_trainer.adoc

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>
* Fix redirect path after blocking a user

* Changed icons
* Remove useless helper methods

* Add Kebab menu for resources

* Fix specs

* Fix follow for resources

* Fix failing specs

* Change column width

* Place Share button in actions row

* lint

* Fix share buttons

* Refactor the endorsers list

* Lint

* Fix failing specs

* Lint

* Remove unused file

* Remove horizontal padding in pop-up

* Apply review recommendation

* Apply review recommendations

* Fixing issues

* Fix failing specs

* Fix rubocop

* Apply review recommendations

* Add spec

* Fix specs

* Upgrade @tarekraafat/autocomplete.js

* Fix dependency

* Apply latest review recommendations

* Fix specs

* Test Aria label

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
* Add Meeting Attendees metric

* Fix TODOs

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>
* Fix permissions in initiatives

* Fix specs

* Add specs
Co-authored-by: Alexandru Emil Lupu <[email protected]>
Co-authored-by: Anna Topalidi <[email protected]>
* Fix newsletter subscriber count

* Running linters

* Add spec
* Update UI design of detail page

* Fix specs

* Fix specs

* Fix spec

* Fix labels

* Fix specs

* Add withdraw icons
* Remove wkhtmltopdf-binary gem and wicked configuration

* Update installation doc

* Add release notes note

* Add wkhtmltopdf package in CI configuration
* Add Open Data page with explanations

* Add download links for each resource in the Open Data page

* Clarify the rspec example about the ZIP file format

* Make the variable naming more resource for the open data examples

* Add missing i18n string

* Run i18n-tasks normalize

* Fix spelling error

* Fix bad merge

* Fix specs

* Add detailed explanation of the files

* Fix file download for resources

* Add specs for OpenDataExporter with resources

* Fix bug with components download

* Fix specs

* Add specs for components

* Fix spec

* Remove duplicated download links

* Replace up arrow with down arrow in accordion

* Add specs for documentation in open data page

* Add license information in Open Data page

* Add license file in Open Data zip

* Fix styling in Open Data page

* Run i18n-tasks normalize
* Fix usage of private_non_transparent_space?

* Update decidim-conferences/spec/system/component_spec.rb

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Refactor specs

* Patch specs - lint

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>
* Fix visibility on assemblies

* Add spec for search

* Update spec
* Add Open Data page with explanations

* Add download links for each resource in the Open Data page

* Clarify the rspec example about the ZIP file format

* Make the variable naming more resource for the open data examples

* Add missing i18n string

* Run i18n-tasks normalize

* Fix spelling error

* Fix bad merge

* Fix specs

* Add profiles to Open Data files

* Running linters

* Fix specs

* Fix file download for resources

* Add specs for OpenDataExporter with resources

* Fix bug with components download

* Fix specs

* Add specs for components

* Fix spec

* Fix spec for bugets' test_field serializer subscription

* Add subtitles for different types of elements

* Refactor exporter

* Lint

* Fix spec

* Update decidim-core/spec/services/decidim/open_data_exporter_spec.rb

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Apply review recommendation

* Add spec for deleted user

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Alexandru Emil Lupu <[email protected]>
mllocs and others added 24 commits December 12, 2024 12:45
* extracted fix from decidim#12348 for condition of votes count when voting is disabled

* removed inundated test for displaying votes always in export
Co-authored-by: Alexandru Emil Lupu <[email protected]>
Co-authored-by: Ivan Vergés <Ivan Vergés>
* updated_at column added.

* updated_at column fixed and test added

* reference column and test added

* author field extracted from debates and added to projects

* methods extracted  to retrieve the author user profile

* renamed the budget id to decidim_budgets_budget_id

* selected_at added including its test

* follows_count extraction and added with test

* longitude and latitude extratced with tests added

* translations added and updated

* Update decidim-budgets/config/locales/en.yml

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Update decidim-budgets/lib/decidim/budgets/project_serializer.rb

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* reverted id and added budget title

* extracted root_url helper for rspec test

* extratced the budget url with test

* translations updated for budget_url

* extracted method to retrieve budget url

* added test to get URL of budget

* removed unused methods from spec

* added title of budget

* Improved the budget component serializer. id, url and title added to hash with test suite

* updated i18n translations

* Update decidim-budgets/config/locales/en.yml

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Update decidim-budgets/config/locales/en.yml

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Update decidim-budgets/lib/decidim/budgets/project_serializer.rb

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Update decidim-budgets/spec/serializers/project_serializer_spec.rb

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Alexandru Emil Lupu <[email protected]>
* Enable sidekiq

* Fix pipeline

* Remove seeds queue
Co-authored-by: Tom Greenwood <[email protected]>
Co-authored-by: Alexandru Emil Lupu <[email protected]>
Co-authored-by: Alejandro Rueda López <[email protected]>
Co-authored-by: MariaDascaluPublicis <[email protected]>
Co-authored-by: Ivan Vergés <[email protected]>
Co-authored-by: Alexandru Emil Lupu <[email protected]>
Co-authored-by: Ivan Vergés <Ivan Vergés>
Co-authored-by: Carolina Romero <[email protected]>
Co-authored-by: Alexandru Emil Lupu <[email protected]>
)

* Add system article and updated screenshots

* Update system article and fix errors

* Fix lint errors

* Fix errors

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Fix codeclimate and typo

* Fix remaining trailing whitespaces

---------

Co-authored-by: paulinebessoles <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

arpi-tremend and others added 4 commits January 7, 2025 09:46
* Block notifications for blocked users

* Add tests for fix_blocked_user_notification task

* Remove trailing whitespaces

* Update RELEASE_NOTES.md

* Update decidim-core/lib/tasks/upgrade/clean.rake

* RELEASE_NOTES.md lint fix

* Remove line 24 from RELEASE_NOTES.md

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

---------

Co-authored-by: Alexandru Emil Lupu <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
* Create HexaPDF survey file

* Finalize the survey export to hexapdf

* Refactor

* Fix specs

* Fix specs

* Refactor Conference diploma to hexaPDF

* Running rubocops

* Fix language file

* Fix failing spec

* Fix the conferences pdf rendering

* Fix spelling

* Fix spelling

* Fix specs
* Upgrade rubocop and Rubocop family

* Patch faker syntax

* Fix Lint/UselessAssignment

* Fix Lint/UselessDefined

* Fix: Rails/WhereEquals

* Fix Rails/PluralizationGrammar

* Fix: Rails/RootPathnameMethods

* Fix Style/RedundantInterpolationUnfreeze

* Fix: Style/FileNull

* Fix RSpec/StringAsInstanceDoubleConstant

* Fix admin specs

* Fix failing specs

* Fix: Lint/SafeNavigationConsistency

* Fix Style/KeywordArgumentsMerging

* Fix Rails/CompactBlank

* Fix Style/SelectByRegexp

* Handle Style/SafeNavigationChainLength

* Add erb exception for Style/SafeNavigationChainLength

* Revert Gemfile

* Revert gemfile

* Revert faker upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.