Master tree map chart adrm #5335
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hokolomopo
force-pushed
the
master-tree-map-chart-adrm
branch
from
0f0ffd3 to
c0b7ac9
Compare
This commit simplifies the use of color scales in the conditional format plugin and export the color scales to an helper. Now we have a simple `getColorScale` helper, that take as argument a number of value/color pairs (the thresholds) and return a function that computes a color based on a value and the provided value/color pairs. All the complexity of the color scale computation is now hidden in the helper, which simplify the use of color scale a lot and allows us to use them in other places. Task: 3265268
Rename the `ChartTitle` component to `TextStyler` to make it sounds more generic and to prepare for the next commits. Task: 4364295
hokolomopo
force-pushed
the
master-tree-map-chart-adrm
branch
from
c0b7ac9 to
ae06daf
Compare
This commit simplifies the `TextStyler` by - delete all the props `updateColor`, `toggleBold`, ... in favor of a single callback `updateStyle` - rename `name` props to `label` to be more explicit - use `ActionButton` components instead of custom HTML that looks like an action button Task: 4364295
Add the possibility of having a `TextStyler` that: - has no text input - can edit vertical algin - can edit text background color - made label optional Task: 4364295
hokolomopo
force-pushed
the
master-tree-map-chart-adrm
branch
from
ae06daf to
bf69c5e
Compare
This commits adds the "treemap" chart type to display hierarchical data. We use the library `https://chartjs-chart-treemap.pages.dev/` that we patch a bit to have the render that we want. Task: 4364295
Task: 4364295
hokolomopo
force-pushed
the
master-tree-map-chart-adrm
branch
from
bf69c5e to
216b503
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMP] charts: add tree map chart
This commits adds the "treemap" chart type to display hierarchical data.
We use the library
https://chartjs-chart-treemap.pages.dev/that wepatch a bit to have the render that we want.
[IMP] chart: add functionalities to
TextStylerAdd the possibility of having a
TextStylerthat:[REF] chart: simplify
TextStylercomponentThis commit simplifies the
TextStylerbyupdateColor,toggleBold, ... in favor of asingle callback
updateStylenameprops tolabelto be more explicitActionButtoncomponents instead of custom HTML that looks likean action button
[MOV] chart: rename
ChartTitletoTextStylerRename the
ChartTitlecomponent toTextStylerto make it soundsmore generic and to prepare for the next commits.
Task: 4364295
review checklist