Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change timezone location #1024

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: change timezone location #1024

wants to merge 3 commits into from

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Jun 9, 2021

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@asbiin asbiin requested a review from a team as a code owner June 9, 2021 21:24
@asbiin asbiin requested review from djaiss and removed request for a team June 9, 2021 21:24
djaiss
djaiss requested changes Jun 10, 2021
View reviewed changes
Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, but why do we need to change the location of the timezone?

app/Http/Middleware/ShareInertiaData.php Outdated Show resolved Hide resolved
app/Services/User/UpdateTimezone.php Show resolved Hide resolved
resources/js/Pages/Profile/Partials/UpdateTimezone.vue Show resolved Hide resolved
@djaiss
Copy link
Member

djaiss commented Jun 11, 2021

Also we probably need to update the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaiss djaiss djaiss requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asbiin @djaiss