Dehumidifier sensor for notification light #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `airState.notificationExt` to get water tank status
* Update water tank full sensor Updated to be based on airState.notificationExt and int rather than bool * Add separate field for notification light, defensive code with logging * Updated to lookup value * Improve logging * Always log notification light value * Keep notification light as integer * Make notification light int * Make the notification light bool again * Cleanup sensor, categorize notification light as problem
ollo69
requested changes
Jan 4, 2025
Comment on lines
+325
to
+333
| try: | ||
| key = self._get_state_key(STATE_NOTIFICATION_LIGHT) | ||
| except: | ||
| key = None | ||
| _LOGGER.exception("LGE ThinQ dehumidifier - unable to get Notification Light status") | ||
| if key is None: | ||
| ntf_real_value = None | ||
| ntf_light_int_value = None | ||
| ntf_light_bool_val = None |
There was a problem hiding this comment.
This will generate a lot of log exception for devices that do not support this feature. Please just return Nonw
Comment on lines
+337
to
+339
| if ntf_light_int_value is None: | ||
| ntf_light_bool_val = None | ||
| _LOGGER.warning(f"LGE ThinQ dehumidifier Notification light is {ntf_real_value}. int {ntf_light_int_value}. bool {ntf_light_bool_val}") |
There was a problem hiding this comment.
Same as above. If we don't have values, return None
Comment on lines
+340
to
+346
| elif ntf_light_int_value > 0: | ||
| ntf_light_bool_val = True | ||
| else: | ||
| ntf_light_bool_val = False | ||
| if ntf_light_bool_val is not None: | ||
| _LOGGER.debug(f"LGE ThinQ dehumidifier Notification light is {ntf_real_value}. int {ntf_light_int_value}. bool {ntf_light_bool_val}") | ||
| return self._update_feature(DehumidifierFeatures.NOTIFICATION_LIGHT, ntf_light_bool_val) |
There was a problem hiding this comment.
At this point you can just simplify with
return self._update_feature(DehumidifierFeatures.NOTIFICATION_LIGHT, ntf_light_int_value > 0, False)
But are you sure that this is an int with value > 0 to define light on?
| @@ -44,6 +47,8 @@ | |||
|
|
|||
| ADD_FEAT_POLL_INTERVAL = 300 # 5 minutes | |||
|
|
|||
| _LOGGER = logging.getLogger(__name__) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sensor for dehumidifier notification light in HA. May also help with #778 if anyone wants to use the notification light as the water tank sensor status doesn't seem to change.