-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Faqgen #1323
Open
XinyaoWa
wants to merge
7
commits into
main
Choose a base branch
from
refactor_faqgen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor Faqgen #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XinyaoWa
requested review from
lvliang-intel,
ftian1 and
chensuyue
as code owners
December 31, 2024 01:36
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files |
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Xinyao Wang <[email protected]>
Signed-off-by: Xinyao Wang <[email protected]>
for more information, see https://pre-commit.ci
XinyaoWa
force-pushed
the
refactor_faqgen
branch
from
January 3, 2025 06:09
a3ffd62
to
4762b24
Compare
for more information, see https://pre-commit.ci
chensuyue
reviewed
Jan 6, 2025
extends: faqgen | ||
image: ${REGISTRY:-opea}/llm-faqgen-tgi:${TAG:-latest} | ||
image: ${REGISTRY:-opea}/llm-faqgen:${TAG:-latest} | ||
llm-docsum-tgi: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example does not require docsum anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related comps PR: opea-project/GenAIComps#1093
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a
.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.