Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm deployment instructions for codegen #1351

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

yongfengdu
Copy link
Collaborator

@yongfengdu yongfengdu commented Jan 6, 2025

Description

The summary of the proposed changes as long as the relevant motivation and context.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Copy link

github-actions bot commented Jan 6, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

@yongfengdu yongfengdu mentioned this pull request Jan 7, 2025
4 tasks
@yongfengdu
Copy link
Collaborator Author

The GMC CI error is due to path changes:
/home/sdp/GenAIExamples-actions-runner-0/_work/GenAIExamples/GenAIExamples/CodeGen/tests/test_gmc_on_xeon.sh: line 115: pushd: CodeGen/kubernetes/intel/cpu/xeon/gmc: No such file or directory

The CI is using upstream version of test_gmc_on_xeon.sh(on pull_request_target), so can only updated after the merge

@yongfengdu yongfengdu marked this pull request as ready for review January 7, 2025 05:00
@chensuyue
Copy link
Collaborator

The GMC CI error is due to path changes: /home/sdp/GenAIExamples-actions-runner-0/_work/GenAIExamples/GenAIExamples/CodeGen/tests/test_gmc_on_xeon.sh: line 115: pushd: CodeGen/kubernetes/intel/cpu/xeon/gmc: No such file or directory

The CI is using upstream version of test_gmc_on_xeon.sh(on pull_request_target), so can only updated after the merge

The test should pass if you update this file,

Copy link
Collaborator

@chensuyue chensuyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@poussa poussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename helm-chart to helm since the directory does not contain Helm chart but helm chart values files.

CodeGen/README.md Outdated Show resolved Hide resolved
CodeGen/kubernetes/helm-chart/cpu-values.yaml Outdated Show resolved Hide resolved
Signed-off-by: Dolpher Du <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants