[pkg/stanza] Log the entry in HandleEntryError when the transformer on_error mode is send_quiet or drop_quiet
#36899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mode is send_quiet or drop_quiet The `HandleEntryError` is used in many places for handling parsing errors. Sometimes the error itself is not very helpful, e.g. the syslog parser return errors like "parsing error [col 66]", which is quite hard to understand without seeing the actual entry. This PR logs the entry when the error mode is `send_quiet` or `drop_quiet` in debug level. It shouldn't add too much noise and could be very helpful in debugging.
namco1992
force-pushed
the
handle-error-log-entry
branch
from
8a264e0 to
83e2848
Compare
djaglowski
requested changes
Dec 20, 2024
I've thought about it too, so I only added it to the quiet mode so it only logs on the debug level. My train of thought is:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
HandleEntryErroris used in many places for handling parsing errors. Sometimes the error itself is not very helpful, e.g. the syslog parser return errors like "parsing error [col 66]", which is quite hard to understand without seeing the actual entry.This PR logs the entry when the error mode is
send_quietordrop_quietin debug level. It shouldn't add too much noise and could be very helpful in debugging.