Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/prometheusremotewrite] only append colliding attributes values if they are different #36928

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avanish-vaghela
Copy link

Description

While translating two OTel attributes into Prometheus Labels, if both attributes results in the same Prometheus label and both have the same value, they won't be appended.

Example:

  • "bar.one": "foo"
  • "bar/one": "foo"

The above two attributes when translated to Prometheus label would become

  • Before the PR
    • "bar_one": "foo;foo"
  • After the PR:
    • "bar_one": "foo"

Link to tracking issue

Fixes #35896

Testing

  • Unit test added

Documentation

  • Change log entry added

@avanish-vaghela avanish-vaghela changed the title feat(prometheusremotewriteexporter): only append colliding attributes… [exporter/prometheusremotewrite] only append colliding attributes values if they are different Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prom rw translation, handle identical values in duplicate labels.
1 participant