Refactor OTLP mock collector test #3849
Conversation
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/MockCollectorIntegrationTests.cs
Outdated
Show resolved
Hide resolved
| })) | ||
| .StartAsync(); | ||
|
|
||
| var httpClient = host.GetTestClient(); |
There was a problem hiding this comment.
can we use a normal httpclient, not the Test "httpclient"?
There was a problem hiding this comment.
Yep, we could. That's what we do in the Grpc.Net.Client tests https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/test/OpenTelemetry.Instrumentation.Grpc.Tests/GrpcServer.cs#L71.
Do we have a preference? I kinda like the TestServer/TestClient as I think it makes the test code more concise. That is, I think it'd be required to find an open port, perform the ConfigureKestrel thing, etc. Not a huge deal, but it's extra noise.
There was a problem hiding this comment.
Ok, you twisted my arm 😄. Still planning on addressing #3393, but this PR is good to go now.
I hard-coded ports for now making sure to use something that doesn't conflict with our other test with a hard-coded port
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3849 +/- ##
=======================================
Coverage 87.34% 87.35%
=======================================
Files 279 279
Lines 10772 10772
=======================================
+ Hits 9409 9410 +1
+ Misses 1363 1362 -1
|
Follow up from #3788 (comment)