Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a console dependency injection logging project to docs section #6014

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShiningMassXAcc
Copy link

Changes

Add a console dependency injection example for logging.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@ShiningMassXAcc ShiningMassXAcc requested a review from a team as a code owner December 7, 2024 00:46
@github-actions github-actions bot added the documentation Documentation related label Dec 7, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.28%. Comparing base (305597d) to head (1b8d099).
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6014      +/-   ##
==========================================
- Coverage   86.31%   86.28%   -0.04%     
==========================================
  Files         257      257              
  Lines       11685    11685              
==========================================
- Hits        10086    10082       -4     
- Misses       1599     1603       +4     
Flag Coverage Δ
unittests-Project-Experimental 86.13% <ø> (+0.29%) ⬆️
unittests-Project-Stable 85.88% <ø> (-0.34%) ⬇️
unittests-Solution 86.21% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@@ -0,0 +1,3 @@
# Console Application with Dependency Injection

This example shows how create a console application with Dependency Injection via `ServiceCollection`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is something OTel should document. It shows getting started guides for simple console app and asp.net core (which implicitly cover DI). It is not recommended to keep expanding the amount of examples in this repo, unless there is a strong reason to.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants