Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add support for extra configuration #6378

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

mattsains
Copy link

@mattsains mattsains commented Nov 27, 2024

Added support for configuring:

  • Certificate
  • ClientCertificate
  • ClientKey

Based on #6376
Partially addresses #6351

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.1%. Comparing base (e97e6e4) to head (9e39964).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
config/config.go 81.8% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6378     +/-   ##
=======================================
+ Coverage   67.0%   67.1%   +0.1%     
=======================================
  Files        193     193             
  Lines      15660   15718     +58     
=======================================
+ Hits       10494   10554     +60     
+ Misses      4876    4875      -1     
+ Partials     290     289      -1     
Files with missing lines Coverage Δ
config/log.go 95.3% <100.0%> (+0.4%) ⬆️
config/metric.go 85.8% <100.0%> (+0.4%) ⬆️
config/trace.go 97.3% <100.0%> (+0.2%) ⬆️
config/config.go 85.0% <81.8%> (-1.1%) ⬇️

... and 1 file with indirect coverage changes

@dmathieu dmathieu marked this pull request as draft December 13, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants