End span after closing scope #12952
Merged
End span after closing scope #12952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
end-span-after-closing-scope
branch
from
6a6ab03 to
fa3e9b6
Compare
laurit
reviewed
Dec 24, 2024
.../src/main/java/io/opentelemetry/instrumentation/okhttp/v3_0/internal/TracingInterceptor.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Dec 24, 2024
| @@ -60,21 +60,20 @@ public void doFilterInternal( | |||
| } | |||
|
|
|||
| Context context = instrumenter.start(parentContext, request); | |||
| if (httpRouteSupport.hasMappings()) { | |||
There was a problem hiding this comment.
I suspect that it was deliberately added after filterChain.doFilter.
There was a problem hiding this comment.
thanks, reverted changes to these two files
laurit
reviewed
Dec 24, 2024
| @@ -60,21 +60,20 @@ public void doFilterInternal( | |||
| } | |||
|
|
|||
| Context context = instrumenter.start(parentContext, request); | |||
| if (httpRouteSupport.hasMappings()) { | |||
There was a problem hiding this comment.
I suspect that it was deliberately added after filterChain.doFilter.
laurit
approved these changes
Dec 25, 2024
jaydeluca
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4596